third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html - Issue 1952463002: Media Stream Image Capture (4): wire takePhoto and implement in FakeVCDevice

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html

Issue 1952463002: Media Stream Image Capture (4): wire takePhoto and implement in FakeVCDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: forgotten "!" and rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« media/capture/video/video_capture_device.cc ('K') | « media/capture/video/video_capture_device.cc ('k') | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src=../../resources/testharness.js></script>	2 <script src=../../resources/testharness.js></script>

3 <script src=../../resources/testharnessreport.js></script>	3 <script src=../../resources/testharnessreport.js></script>

4 <body>	4 <body>

5 <canvas id='canvas0' width=10 height=10/>	5 <canvas id='canvas0' width=10 height=10/>

6 </body>	6 </body>

7 <script>	7 <script>

8	8

9 // This test verifies ImageCapture's takePhoto().	9 // This test verifies ImageCapture's takePhoto().

10	10

11 var test = async_test(function() {	11 var test = async_test(function() {

12 var canvas0 = document.getElementById('canvas0');	12 var canvas0 = document.getElementById('canvas0');

13 var context0 = canvas0.getContext("2d");	13 var context0 = canvas0.getContext("2d");

14 context0.fillStyle = "red";	14 context0.fillStyle = "red";

15 context0.fillRect(0, 0, 10, 10);	15 context0.fillRect(0, 0, 10, 10);

16	16

17 var stream = canvas0.captureStream();	17 var stream = canvas0.captureStream();

18	18

19 var capturer = new ImageCapture(stream.getVideoTracks()[0]);	19 var capturer = new ImageCapture(stream.getVideoTracks()[0]);

20	20

21 capturer.takePhoto()	21 capturer.takePhoto()

22 .then(blob => {	22 .then(blob => {

23 assert_true(blob.type.length > 0);	23 assert_unreached('takePhoto() should not have been resolved');

24 assert_true(blob.size > 0);

25 this.done();

26 })	24 })

27 .catch(error => {	25 .catch(error => {

28 assert_unreached('Error during takePhoto(): '+ error);	26 // LayoutTests do not have a real or a fake camera whatsoever, so content

	27 // will not find a matching device for the Track's source id, and the

	28 // promise will be rejected.
	mlamouri (slow - plz ping) 2016/05/09 12:44:35 Are you planning to fix this? Should you have a TO Are you planning to fix this? Should you have a TODO pointing to a bug in order to add a mock in the test runner? mcasas 2016/05/09 16:48:41 Done. It essentially means tapping the source id b Show quoted text On 2016/05/09 12:44:35, Mounir Lamouri wrote: > Are you planning to fix this? Should you have a TODO pointing to a bug in order > to add a mock in the test runner? Done. It essentially means tapping the source id being passed around, and then having a mojo mock interface implementation a la USB (with a mojo mock "service" in JS).
	29 this.done();

29 });	30 });

30 }, 'exercises the ImageCapture API takePhoto().');	31 }, 'exercises the ImageCapture API takePhoto().');

31	32

32 </script>	33 </script>

OLD	NEW