Media Stream Image Capture (4): wire takePhoto and implement in FakeVCDevice

media/capture/video/video_capture_device.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/video_capture_device.h"
 
 #include "base/command_line.h"
 #include "base/i18n/timezone.h"
 #include "base/macros.h"
 #include "base/strings/string_util.h"
@@ skipping 123 matching lines @@
   }
 }
 #endif
 
 VideoCaptureDevice::Client::Buffer::~Buffer() {
 }
 
 VideoCaptureDevice::~VideoCaptureDevice() {
 }
 
+bool VideoCaptureDevice::TakePhoto(
+    const TakePhotoCallback& /* photo_callback */) {

[tommi (sloooow) - chröme, 2016/05/09 11:17:33]

since we generally don't use /* */ comment style, suggest to just leave the
variable in there.

[mcasas, 2016/05/09 16:48:41]

Done.

+  NOTIMPLEMENTED();
+  return false;
+}
+
 PowerLineFrequency VideoCaptureDevice::GetPowerLineFrequencyForLocation()
     const {
   const std::string current_country = base::CountryCodeForCurrentTimezone();
   if (current_country.empty())
     return PowerLineFrequency::FREQUENCY_DEFAULT;
   // Sorted out list of countries with 60Hz power line frequency, from
   // http://en.wikipedia.org/wiki/Mains_electricity_by_country
   const char* countries_using_60Hz[] = {
       "AI", "AO", "AS", "AW", "AZ", "BM", "BR", "BS", "BZ", "CA", "CO",
       "CR", "CU", "DO", "EC", "FM", "GT", "GU", "GY", "HN", "HT", "JP",
@@ skipping 13 matching lines @@
   switch (params.power_line_frequency) {
     case media::PowerLineFrequency::FREQUENCY_50HZ:  // fall through
     case media::PowerLineFrequency::FREQUENCY_60HZ:
       return params.power_line_frequency;
     default:
       return GetPowerLineFrequencyForLocation();
   }
 }
 
 }  // namespace media