Media Stream Image Capture (4): wire takePhoto and implement in FakeVCDevice

media/capture/video/fake_video_capture_device_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/fake_video_capture_device.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/thread.h"
 #include "build/build_config.h"
 #include "media/base/media_switches.h"
 #include "media/base/video_capture_types.h"
 #include "media/capture/video/fake_video_capture_device_factory.h"
 #include "media/capture/video/video_capture_device.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/codec/png_codec.h"
 
 using ::testing::_;
 using ::testing::Bool;
 using ::testing::Combine;
 using ::testing::SaveArg;
 using ::testing::Values;
 
 namespace media {
 
 namespace {
@@ skipping 89 matching lines @@
   void OnEnumeratedDevicesCallback(
       std::unique_ptr<VideoCaptureDevice::Names> names) {
     OnEnumeratedDevicesCallbackPtr(names.release());
   }
 
  private:
   friend class base::RefCounted<DeviceEnumerationListener>;
   virtual ~DeviceEnumerationListener() {}
 };
 
+class PhotoTakenListener : public base::RefCounted<PhotoTakenListener> {
+ public:
+  MOCK_METHOD0(OnCorrectPhotoTaken, void(void));
+  // GMock doesn't support move-only arguments, so we use this forward method.
+  void DoOnPhotoTaken(const std::string& mime_type,
+                      std::unique_ptr<std::vector<uint8_t>> data) {
+    // Only PNG images are supported right now.
+    EXPECT_STREQ("image/png", mime_type.c_str());
+
+    std::vector<unsigned char> decoded;
+    int width, height;
+    ASSERT_TRUE(gfx::PNGCodec::Decode(data->data(), data->size(),

[miu, 2016/05/05 22:04:24]

Your call, but it feels a bit heavyweight for the unit test to try and decode
the image data. (The layout tests can do this, and also examine the content of
the image.) IMO, just check for a non-empty vector here.

[mcasas, 2016/05/05 23:05:50]

Done.

+                                      gfx::PNGCodec::FORMAT_RGB, &decoded,
+                                      &width, &height));
+
+    EXPECT_GT(decoded.size(), 0u);
+    EXPECT_GT(width, 0);
+    EXPECT_GT(height, 0);
+    OnCorrectPhotoTaken();
+  }
+
+ private:
+  friend class base::RefCounted<PhotoTakenListener>;
+  virtual ~PhotoTakenListener() {}
+};
+
 }  // namespace
 
 class FakeVideoCaptureDeviceBase : public ::testing::Test {
  protected:
   FakeVideoCaptureDeviceBase()
       : loop_(new base::MessageLoop()),
         client_(new MockClient(
             base::Bind(&FakeVideoCaptureDeviceBase::OnFrameCaptured,
                        base::Unretained(this)))),
-        video_capture_device_factory_(new FakeVideoCaptureDeviceFactory()) {
-    device_enumeration_listener_ = new DeviceEnumerationListener();
-  }
+        device_enumeration_listener_(new DeviceEnumerationListener()),
+        photo_taken_listener_(new PhotoTakenListener()),
+        video_capture_device_factory_(new FakeVideoCaptureDeviceFactory()) {}
 
   void SetUp() override { EXPECT_CALL(*client_, OnError(_, _)).Times(0); }
 
   void OnFrameCaptured(const VideoCaptureFormat& format) {
     last_format_ = format;
     run_loop_->QuitClosure().Run();
   }
 
   void WaitForCapturedFrame() {
     run_loop_.reset(new base::RunLoop());
@@ skipping 11 matching lines @@
     base::MessageLoop::current()->RunUntilIdle();
     return std::unique_ptr<VideoCaptureDevice::Names>(names);
   }
 
   const VideoCaptureFormat& last_format() const { return last_format_; }
 
   VideoCaptureDevice::Names names_;
   const std::unique_ptr<base::MessageLoop> loop_;
   std::unique_ptr<base::RunLoop> run_loop_;
   std::unique_ptr<MockClient> client_;
-  scoped_refptr<DeviceEnumerationListener> device_enumeration_listener_;
+  const scoped_refptr<DeviceEnumerationListener> device_enumeration_listener_;
+  const scoped_refptr<PhotoTakenListener> photo_taken_listener_;
   VideoCaptureFormat last_format_;
   const std::unique_ptr<VideoCaptureDeviceFactory>
       video_capture_device_factory_;
 };
 
 class FakeVideoCaptureDeviceTest
     : public FakeVideoCaptureDeviceBase,
       public ::testing::WithParamInterface<
           ::testing::tuple<FakeVideoCaptureDevice::BufferOwnership, float>> {};
 
@@ skipping 56 matching lines @@
     EXPECT_EQ(supported_formats[2].frame_size.height(), 720);
     EXPECT_EQ(supported_formats[2].pixel_format, PIXEL_FORMAT_I420);
     EXPECT_GE(supported_formats[2].frame_rate, 20.0);
     EXPECT_EQ(supported_formats[3].frame_size.width(), 1920);
     EXPECT_EQ(supported_formats[3].frame_size.height(), 1080);
     EXPECT_EQ(supported_formats[3].pixel_format, PIXEL_FORMAT_I420);
     EXPECT_GE(supported_formats[3].frame_rate, 20.0);
   }
 }
 
+TEST_F(FakeVideoCaptureDeviceTest, TakePhoto) {
+  std::unique_ptr<VideoCaptureDevice> device(new FakeVideoCaptureDevice(
+      FakeVideoCaptureDevice::BufferOwnership::OWN_BUFFERS, 30.0));
+  ASSERT_TRUE(device);
+
+  VideoCaptureParams capture_params;
+  capture_params.requested_format.frame_size.SetSize(640, 480);
+  capture_params.requested_format.frame_rate = 30.0;
+  device->AllocateAndStart(capture_params, std::move(client_));
+
+  const VideoCaptureDevice::TakePhotoCallback photo_callback =
+      base::Bind(&PhotoTakenListener::DoOnPhotoTaken, photo_taken_listener_);
+  EXPECT_CALL(*photo_taken_listener_.get(), OnCorrectPhotoTaken()).Times(1);
+  ASSERT_TRUE(device->TakePhoto(photo_callback));
+
+  run_loop_.reset(new base::RunLoop());
+  run_loop_->Run();
+  device->StopAndDeAllocate();
+}
+
 TEST_P(FakeVideoCaptureDeviceCommandLineTest, FrameRate) {
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kUseFakeDeviceForMediaStream, GetParam().argument);
   const std::unique_ptr<VideoCaptureDevice::Names> names(EnumerateDevices());
   ASSERT_FALSE(names->empty());
 
   for (const auto& names_iterator : *names) {
     std::unique_ptr<VideoCaptureDevice> device =
         video_capture_device_factory_->Create(names_iterator);
     ASSERT_TRUE(device);
@@ skipping 11 matching lines @@
   }
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         FakeVideoCaptureDeviceCommandLineTest,
                         Values(CommandLineTestData{"fps=-1", 5},
                                CommandLineTestData{"fps=29.97", 29.97f},
                                CommandLineTestData{"fps=60", 60},
                                CommandLineTestData{"fps=1000", 60}));
 };  // namespace media