Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1952453002: Bring in the latest watcher, collection, and async. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update collection and async as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nweiz
4 years, 7 months ago (2016-05-03 21:17:33 UTC) #2
Paul Berry
I tried patching in this change and running the analyzer tests, and I'm seeing a ...
4 years, 7 months ago (2016-05-03 21:46:22 UTC) #3
nweiz
PTAL All analyzer tests are now passing :).
4 years, 7 months ago (2016-05-03 22:46:08 UTC) #5
Paul Berry
lgtm
4 years, 7 months ago (2016-05-03 23:14:24 UTC) #6
nweiz
4 years, 7 months ago (2016-05-03 23:15:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2dd8bee5405f681bf13bfa394f9ed519d583ebb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698