Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: net/http/http_stream_factory_impl_job_controller.h

Issue 1952423002: JobController 2: Remove reference between HttpStreamFactoryImpl::Jobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Job_Controller_1
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller.h
diff --git a/net/http/http_stream_factory_impl_job_controller.h b/net/http/http_stream_factory_impl_job_controller.h
index 230fa6f19fd8d2ce3e137fbdfeca0291a7522cb6..68d4cfa797d2913403ee48424cd8f258afb7596f 100644
--- a/net/http/http_stream_factory_impl_job_controller.h
+++ b/net/http/http_stream_factory_impl_job_controller.h
@@ -117,6 +117,9 @@ class HttpStreamFactoryImpl::JobController {
// Invoked when an orphaned Job finishes.
void OnOrphanedJobComplete(const Job* job);
+ // Removes cached reference to |job|.
+ void OnJobDeletion(Job* job);
+
// Called by an attached Job to record connection attempts made by the socket
// layer to |request_|.
void AddConnectionAttemptsToRequest(const ConnectionAttempts& attempts);
@@ -132,6 +135,8 @@ class HttpStreamFactoryImpl::JobController {
void MaybeNotifyFactoryOfCompletion();
+ void MaybeResumeOtherJob(Job* job, const base::TimeDelta& delay);
+
const BoundNetLog& GetNetLogFromRequest() const;
SpdySessionRequestMap& GetSpdySessionRequestMap() {
@@ -140,6 +145,8 @@ class HttpStreamFactoryImpl::JobController {
bool for_websockets() { return factory_->for_websockets_; }
+ bool racing() { return racing_; }
+
WebSocketHandshakeStreamBase::CreateHelper*
websocket_handshake_stream_create_helper();
@@ -167,6 +174,9 @@ class HttpStreamFactoryImpl::JobController {
Job* main_job_;
Job* alternative_job_;
+ // True if the |main_job_| has to wait for |alternative_job_|;
+ bool racing_;
Ryan Hamilton 2016/05/06 21:33:14 If this is about the alt job blocking the main job
Zhongyi Shi 2016/05/13 00:31:25 Done.
+
// At the point where a Job is irrevocably tied to |request_|, we set this.
std::unique_ptr<Job> bound_job_;

Powered by Google App Engine
This is Rietveld 408576698