JobController 2: Remove reference between HttpStreamFactoryImpl::Jobs.

net/http/http_stream_factory_impl_job_controller.h

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_CONTROLLER_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_CONTROLLER_H_
 
 #include "net/http/http_stream_factory_impl.h"
 
 namespace net {
@@ skipping 31 matching lines @@
 
   // Called when |request_| is destructed.
   // Job(s) associated with but not bound to |request_| will be deleted.
   // |request_| and |bound_job_| will be nulled if ever set.
   void OnRequestComplete();
 
   int RestartTunnelWithProxyAuth(const AuthCredentials& credentials);
 
   void SetPriority(RequestPriority priority);
 
-  // Methods below are called by HttpStreamFactoryImpl::Job only.
+  // Methods below are called by HttpStreamFactoryImpl::Job only
   void OnStreamReady(Job* job,
                      const SSLConfig& used_ssl_config,
                      const ProxyInfo& used_proxy_info);
   void OnBidirectionalStreamImplReady(Job* job,
                                       const SSLConfig& used_ssl_config,
                                       const ProxyInfo& used_proxy_info);
   void OnWebSocketHandshakeStreamReady(Job* job,
                                        const SSLConfig& used_ssl_config,
                                        const ProxyInfo& used_proxy_info,
                                        WebSocketHandshakeStreamBase* stream);
@@ skipping 43 matching lines @@
 
   // Called when |job| determines the appropriate |spdy_session_key| for the
   // Request. Note that this does not mean that SPDY is necessarily supported
   // for this SpdySessionKey, since we may need to wait for NPN to complete
   // before knowing if SPDY is available.
   void SetSpdySessionKey(Job* job, const SpdySessionKey& spdy_session_key);
 
   // Remove session from the SpdySessionRequestMap.
   void RemoveRequestFromSpdySessionRequestMapForJob(Job* job);
 
+  void MaybeResumeOtherJob(Job* job, const base::TimeDelta& delay);
+
+  void SetWaitTimeForMainJob(const base::TimeDelta& delay) {
+    wait_time_ = delay;

[Ryan Hamilton, 2016/05/17 22:14:09]

nit: wait_time_for_main_job_  and set_wait_time_for_main_job()

[Zhongyi Shi, 2016/06/29 21:49:03]

Done.

+  }
+
+  const base::TimeDelta& GetWaitTime() const { return wait_time_; }
+
+  // Resume |job| with appropriate wait time. Return false if |job| has no
+  // blocking job and there's no wait time, i.e., |job| won't call
+  // Job::ResumeAfterDelay().
+  bool ResumeJobWithDelay(Job* job) const;
+
   const BoundNetLog* GetNetLog(Job* job) const;
 
+  bool blocking() { return blocking_; }
+
   WebSocketHandshakeStreamBase::CreateHelper*
   websocket_handshake_stream_create_helper();
 
  private:
   FRIEND_TEST_ALL_PREFIXES(HttpStreamFactoryImplRequestTest, SetPriority);
   FRIEND_TEST_ALL_PREFIXES(HttpStreamFactoryImplRequestTest, DelayMainJob);
 
   // Creates Job(s) for |request_|. Job(s) will be owned by |this|.
   void CreateJobs(const HttpRequestInfo& request_info,
                   RequestPriority priority,
@@ skipping 59 matching lines @@
 
   // |main_job_| is a job waiting to see if |alternative_job_| can reuse a
   // connection. If |alternative_job_| is unable to do so, |this| will notify
   // |main_job_| to proceed and then race the two jobs.
   std::unique_ptr<Job> main_job_;
   std::unique_ptr<Job> alternative_job_;
 
   // True if a Job has ever been bound to the |request_|.
   bool job_bound_;
 
+  // True if the |main_job_| has to wait for |alternative_job_|;
+  bool blocking_;

[Ryan Hamilton, 2016/05/17 22:14:09]

Can you expand this comment a bit? Under what circumstances would we have both
jobs, but not be blocking?

+  base::TimeDelta wait_time_;

[Ryan Hamilton, 2016/05/17 22:14:09]

Comment?

+
   // At the point where a Job is irrevocably tied to |request_|, we set this.
   // It will be nulled when the |request_| is finished.
   Job* bound_job_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_CONTROLLER_H_