Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1952413002: cc: Remove remaining calls to LayerImpl::child_at in LayerTreeTests (Closed)

Created:
4 years, 7 months ago by ajuma
Modified:
4 years, 7 months ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove remaining calls to LayerImpl::child_at in LayerTreeTests There were two LayerTreeTests still making calls to LayerImpl::child_at. This CL replaces those calls with calls to LayerTreeImpl::LayerById. BUG=604467 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8587a0b3356d604d5f6f382a2a33f8dc31935dbb Cr-Commit-Position: refs/heads/master@{#392084}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +18 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ajuma
4 years, 7 months ago (2016-05-06 13:23:09 UTC) #4
jaydasika
On 2016/05/06 13:23:09, ajuma wrote: lgtm
4 years, 7 months ago (2016-05-06 16:20:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952413002/20001
4 years, 7 months ago (2016-05-06 17:06:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 17:14:46 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 17:16:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8587a0b3356d604d5f6f382a2a33f8dc31935dbb
Cr-Commit-Position: refs/heads/master@{#392084}

Powered by Google App Engine
This is Rietveld 408576698