Split TickSample and Sampler.

Split TickSample and Sampler.

Since we are going to move Sampler as library, we creates tick-sample.[h|cc] for
TickSample, in order to maintain legacy code.

BUG=v8:4994
LOG=n

Committed: https://crrev.com/96aba388a19392209bf520723504d10c89a2f8a4
Cr-Commit-Position: refs/heads/master@{#36267}

[lpy, 2016-05-06 00:01:32]

lpy@chromium.org changed reviewers:
+ alph@chromium.org

[lpy, 2016-05-06 00:01:32]

PTAL.

[alph, 2016-05-13 00:01:05]

lgtm. Could you please reduce the similarity threshold to keep the history on
tick-sample.

[alph, 2016-05-13 00:39:07]

https://codereview.chromium.org/1952393002/diff/1/src/profiler/sampler.h
File src/profiler/sampler.h (left):

https://codereview.chromium.org/1952393002/diff/1/src/profiler/sampler.h#oldc...
src/profiler/sampler.h:145: class SimulatorHelper : AllStatic {
This should also stay along with TickSample in v8. Though you can move it in a
separate patch.

[lpy, 2016-05-13 07:21:36]

lpy@chromium.org changed reviewers:
+ fmeawad@chromium.org, jochen@chromium.org, yangguo@chromium.org

[lpy, 2016-05-13 07:21:37]

jochen@, yang@, PTAL. I will address alph's comments later.

[lpy, 2016-05-13 21:29:04]

PTAL.

https://codereview.chromium.org/1952393002/diff/1/src/profiler/sampler.h
File src/profiler/sampler.h (left):

https://codereview.chromium.org/1952393002/diff/1/src/profiler/sampler.h#oldc...
src/profiler/sampler.h:145: class SimulatorHelper : AllStatic {
On 2016/05/13 00:39:07, alph wrote:
> This should also stay along with TickSample in v8. Though you can move it in a
> separate patch.

Done.

[alph, 2016-05-13 21:38:40]

https://codereview.chromium.org/1952393002/diff/1/src/profiler/sampler.h
File src/profiler/sampler.h (left):

https://codereview.chromium.org/1952393002/diff/1/src/profiler/sampler.h#oldc...
src/profiler/sampler.h:145: class SimulatorHelper : AllStatic {
On 2016/05/13 21:29:04, lpy wrote:
> On 2016/05/13 00:39:07, alph wrote:
> > This should also stay along with TickSample in v8. Though you can move it in
a
> > separate patch.
> 
> Done.

Thanks. Looks even better now!

[lpy, 2016-05-14 00:04:13]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-05-14 00:04:13]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/1952393002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-14 00:04:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952393002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952393002/60001

[commit-bot: I haz the power, 2016-05-14 00:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-14 00:08:48]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15265)

[lpy, 2016-05-16 22:25:34]

This is kind of blocking the land of sampler library, yang@ and jochen@, could
you please take a look?

[Yang, 2016-05-17 05:25:27]

On 2016/05/16 22:25:34, lpy wrote:
> This is kind of blocking the land of sampler library, yang@ and jochen@, could
> you please take a look?

LGTM. I'm not mistaken that this is just refactoring, right?

[lpy, 2016-05-17 05:30:20]

On 2016/05/17 05:25:27, Yang wrote:
> On 2016/05/16 22:25:34, lpy wrote:
> > This is kind of blocking the land of sampler library, yang@ and jochen@,
could
> > you please take a look?
> 
> LGTM. I'm not mistaken that this is just refactoring, right?

Yes, this patch only splits sampler.[h|cc] and updates related include.

[lpy, 2016-05-17 05:30:43]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2016-05-17 05:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952393002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952393002/60001

[alph, 2016-05-17 05:48:04]

On 2016/05/17 05:25:27, Yang wrote:
> On 2016/05/16 22:25:34, lpy wrote:
> > This is kind of blocking the land of sampler library, yang@ and jochen@,
could
> > you please take a look?
> 
> LGTM. I'm not mistaken that this is just refactoring, right?

Yes, tick-sample will stay in v8, and sampler.{cc,h} will go into the library.

[commit-bot: I haz the power, 2016-05-17 06:11:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 06:12:34]

Description was changed from

==========
Split TickSample and Sampler.

Since we are going to move Sampler as library, we creates tick-sample.[h|cc] for
TickSample, in order to maintain legacy code.

BUG=v8:4994
LOG=n
==========

to

==========
Split TickSample and Sampler.

Since we are going to move Sampler as library, we creates tick-sample.[h|cc] for
TickSample, in order to maintain legacy code.

BUG=v8:4994
LOG=n

Committed: https://crrev.com/96aba388a19392209bf520723504d10c89a2f8a4
Cr-Commit-Position: refs/heads/master@{#36267}
==========

[commit-bot: I haz the power, 2016-05-17 06:12:35]

Patchset 4 (id:??) landed as
https://crrev.com/96aba388a19392209bf520723504d10c89a2f8a4
Cr-Commit-Position: refs/heads/master@{#36267}