Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952383003: Incorporate scale into GrStyle and GrShape (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixapply
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rm extra space #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : Address comment #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -40 lines) Patch
M src/gpu/GrShape.h View 1 2 chunks +11 lines, -4 lines 0 comments Download
M src/gpu/GrShape.cpp View 1 2 6 chunks +22 lines, -10 lines 0 comments Download
M src/gpu/GrStyle.h View 1 3 chunks +14 lines, -10 lines 0 comments Download
M src/gpu/GrStyle.cpp View 1 2 3 4 5 chunks +19 lines, -7 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 2 3 8 chunks +77 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 1957363002 Patch 60001
Issue 1957363002 Patch 80001

Messages

Total messages: 23 (12 generated)
bsalomon
4 years, 7 months ago (2016-05-06 16:55:51 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1952383003/diff/60001/src/gpu/GrStyle.cpp File src/gpu/GrStyle.cpp (right): https://codereview.chromium.org/1952383003/diff/60001/src/gpu/GrStyle.cpp#newcode41 src/gpu/GrStyle.cpp:41: // 1. WriteKey with apply == kPathEffectAndStrokeRec = ...
4 years, 7 months ago (2016-05-09 12:16:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952383003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952383003/80001
4 years, 7 months ago (2016-05-09 13:58:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/8398)
4 years, 7 months ago (2016-05-09 14:01:44 UTC) #9
bsalomon
https://codereview.chromium.org/1952383003/diff/60001/src/gpu/GrStyle.cpp File src/gpu/GrStyle.cpp (right): https://codereview.chromium.org/1952383003/diff/60001/src/gpu/GrStyle.cpp#newcode41 src/gpu/GrStyle.cpp:41: // 1. WriteKey with apply == kPathEffectAndStrokeRec On 2016/05/09 ...
4 years, 7 months ago (2016-05-09 16:19:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952383003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952383003/80001
4 years, 7 months ago (2016-05-09 16:19:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/8407)
4 years, 7 months ago (2016-05-09 16:24:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952383003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952383003/100001
4 years, 7 months ago (2016-05-09 16:31:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/8436)
4 years, 7 months ago (2016-05-09 16:34:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952383003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952383003/100001
4 years, 7 months ago (2016-05-09 19:44:44 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:02:06 UTC) #23
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/97fd2d42b97104fa32a58d7e7a5b7255913f9c9d

Powered by Google App Engine
This is Rietveld 408576698