Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1952383002: Fixes GN boringssl deps path (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, jsimmons1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes GN boringssl deps path The Mojo tree already DEPSes in boringssl into its //third_party. To avoid DEPSing in two boringssl's, we need to look for the one there. (The GN 'check' routine requires the sources to be found even if noone depends on them.) Flutter will need to move its boringssl DEPS from //dart/third_party/boringssl to //third_party/boringssl to match. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d55b87d622a92a2cf90503e9c6fd9cc2241a2872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
This change is needed to roll the runtime for Mojo.
4 years, 7 months ago (2016-05-05 23:03:04 UTC) #2
Cutch
lgtm
4 years, 7 months ago (2016-05-05 23:04:16 UTC) #3
zra
4 years, 7 months ago (2016-05-05 23:07:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d55b87d622a92a2cf90503e9c6fd9cc2241a2872 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698