Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1952363002: Revert of Roll libjpeg-turbo to 1.4.90 and update gn file (Closed)

Created:
4 years, 7 months ago by Dmitry Skiba
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll libjpeg-turbo to 1.4.90 and update gn file (patchset #5 id:80001 of https://codereview.chromium.org/1935113002/ ) Reason for revert: Broke Android x86 Builder (dbg): FAILED: libblimp_client_android.so libblimp_client_android.so.TOC lib.unstripped/libblimp_client_android.so ld.gold: warning: shared library text segment is not shareable ld.gold: error: treating warnings as errors https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/4321/steps/compile/logs/stdio Reverting this change locally fixes the issue. Original issue's description: > Roll libjpeg-turbo to 1.4.90 and update gn file > > Includes the following commits: > > Add PRIVATE flags to global symbols > 51655203fbc949e6423dcd13ce22fe30ab5b5ea2 > > Fix INLINE macro on Windows > 9fee17f77cb7bf0f543f9f4a77b20edbde4c2c04 > > Update to libjpeg_turbo 1.4.90 > 0d47d2d3a728e78676a15b1d818cc668cb7e5a9c > > Add default variable 'use_system_yasm%': > 9d35298a6223278a66423f828a949d93d94d5911 > > Update README.chromium about the 32-bit argument patch > c653af70b7b2bbd3e8cd16c17bc2705cf25b1469 > > BUG=608347 > > Committed: https://crrev.com/346f74fb31a84f8453e885337e0765576b4f35b6 > Cr-Commit-Position: refs/heads/master@{#391883} TBR=thakis@chromium.org,noel@chromium.org,scroggo@chromium.org,fbarchard@chromium.org,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -54 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 3 chunks +50 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Skiba
Created Revert of Roll libjpeg-turbo to 1.4.90 and update gn file
4 years, 7 months ago (2016-05-05 21:40:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952363002/1
4 years, 7 months ago (2016-05-05 21:41:20 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-05 21:41:22 UTC) #4
fbarchard1
On 2016/05/05 21:41:22, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 7 months ago (2016-05-05 21:52:02 UTC) #5
Dmitry Skiba
4 years, 7 months ago (2016-05-05 21:53:18 UTC) #6
On 2016/05/05 21:52:02, fbarchard1 wrote:
> On 2016/05/05 21:41:22, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet. 
> > CQ run can only be started by full committers or once the patch has
> > received an L-G-T-M from a full committer.
> > Even if an L-G-T-M may have been provided, it was from a non-committer,
> > _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
> 
> lgtm
> The rollback is fine, but could you look into --no-warn-shared-textrel
>
http://stackoverflow.com/questions/19986523/shared-library-text-segment-is-no...
> I would like to see the 1.4 aarch64 support

Actually I'm talking to msarett now, we're trying to fix it...

Powered by Google App Engine
This is Rietveld 408576698