use icf=safe w/ gcc+gold+x86/x64, icf=all w/ gold elsewhere.

use icf=safe w/ gcc+gold+x86/x64, icf=all w/ gold elsewhere.

This is another attempt to fix which flags we use by default when
linking w/ gold. The interaction of gold + gcc on intel platforms
appears buggy, so we only use icf=safe there; gold + gcc on non-intel
platforms, and gold + clang on intel can use icf=all, as long
as we have the latest binutils.

This change is GN-only, since linux GYP builds are on their last
breaths and it's not worth worrying about x86 flags there.

R=mcgrathr@chromium.org, thakis@chromium.org
BUG=576197
Committed: https://crrev.com/a403dd9d7c3b7d3619da3ef989f4666e1e11cf95
Cr-Commit-Position: refs/heads/master@{#393563}

[Dirk Pranke, 2016-05-05 22:35:53]

This patch depends on the latest version of binutils that Roland is rolling in
...

[Roland McGrath, 2016-05-05 23:29:50]

lgtm

[Dirk Pranke, 2016-05-13 01:24:58]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-05-13 01:25:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952353004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952353004/1

[commit-bot: I haz the power, 2016-05-13 01:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 01:28:39]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Dirk Pranke, 2016-05-13 16:10:08]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-05-13 16:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mcgrathr@chromium.org
Link to the patchset: https://codereview.chromium.org/1952353004/#ps20001
(title: "s/target_arch/target_cpu")

[commit-bot: I haz the power, 2016-05-13 16:10:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952353004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952353004/20001

[commit-bot: I haz the power, 2016-05-13 17:20:12]

Committed patchset #2 (id:20001)

[Nico, 2016-05-13 17:21:36]

Wait, what? Wasn't the consensus that icf=all should be as safe on 32-bit as on
64-bit with the newest binutils?

[Nico, 2016-05-13 17:22:05]

...nvm, missed the is_clang bit. all good.

[commit-bot: I haz the power, 2016-05-13 17:22:09]

Description was changed from

==========
use icf=safe w/ gcc+gold+x86/x64, icf=all w/ gold elsewhere.

This is another attempt to fix which flags we use by default when
linking w/ gold. The interaction of gold + gcc on intel platforms
appears buggy, so we only use icf=safe there; gold + gcc on non-intel
platforms, and gold + clang on intel can use icf=all, as long
as we have the latest binutils.

This change is GN-only, since linux GYP builds are on their last
breaths and it's not worth worrying about x86 flags there.

R=mcgrathr@chromium.org, thakis@chromium.org
BUG=576197
==========

to

==========
use icf=safe w/ gcc+gold+x86/x64, icf=all w/ gold elsewhere.

This is another attempt to fix which flags we use by default when
linking w/ gold. The interaction of gold + gcc on intel platforms
appears buggy, so we only use icf=safe there; gold + gcc on non-intel
platforms, and gold + clang on intel can use icf=all, as long
as we have the latest binutils.

This change is GN-only, since linux GYP builds are on their last
breaths and it's not worth worrying about x86 flags there.

R=mcgrathr@chromium.org, thakis@chromium.org
BUG=576197

Committed: https://crrev.com/a403dd9d7c3b7d3619da3ef989f4666e1e11cf95
Cr-Commit-Position: refs/heads/master@{#393563}
==========

[commit-bot: I haz the power, 2016-05-13 17:22:10]

Patchset 2 (id:??) landed as
https://crrev.com/a403dd9d7c3b7d3619da3ef989f4666e1e11cf95
Cr-Commit-Position: refs/heads/master@{#393563}