Show message to indicate that mirriring with more than 3 display is not supported.

Show message to indicate that mirriring with more than 3 display is not supported.

BUG=608027
TEST=covered by unit test

Committed: https://crrev.com/211a822288a0346b72182cd57d075787777ddc33
Cr-Commit-Position: refs/heads/master@{#392136}

[oshima, 2016-05-05 22:34:59]

Patchset #1 (id:1) has been deleted

[oshima, 2016-05-05 22:35:05]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-05-05 22:45:22]

Description was changed from

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=
==========

to

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
==========

[oshima, 2016-05-05 22:45:26]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-05-05 22:45:35]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-05-05 22:45:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952353003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952353003/60001

[commit-bot: I haz the power, 2016-05-05 23:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:03:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-05-06 02:13:17]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 02:13:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952353003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952353003/80001

[oshima, 2016-05-06 02:14:13]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-05-06 02:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 02:46:55]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-05-06 03:50:58]

oshima@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-05-06 16:03:51]

https://codereview.chromium.org/1952353003/diff/80001/ash/ash_chromeos_string...
File ash/ash_chromeos_strings.grdp (right):

https://codereview.chromium.org/1952353003/diff/80001/ash/ash_chromeos_string...
ash/ash_chromeos_strings.grdp:443: Mirroring with more than 3 displays is not
supported.
Is the limit displays <= 2, or displays <= 3 ? If it is <= 2 this should say:

Mirroring with more than two displays is not supported.

(Either way spell out the number)

https://codereview.chromium.org/1952353003/diff/80001/ash/display/display_con...
File ash/display/display_configuration_controller.cc (right):

https://codereview.chromium.org/1952353003/diff/80001/ash/display/display_con...
ash/display/display_configuration_controller.cc:86: if
(display_manager_->num_connected_displays() > 2) {
This looks like mirroring is only allowed for 2 displays, not 3?

https://codereview.chromium.org/1952353003/diff/80001/ash/display/display_uti...
File ash/display/display_util.cc (right):

https://codereview.chromium.org/1952353003/diff/80001/ash/display/display_uti...
ash/display/display_util.cc:468: for
(message_center::NotificationList::Notifications::const_iterator iter =
nit: for (const auto iter : notifications)

[oshima, 2016-05-06 18:47:04]

https://codereview.chromium.org/1952353003/diff/80001/ash/ash_chromeos_string...
File ash/ash_chromeos_strings.grdp (right):

https://codereview.chromium.org/1952353003/diff/80001/ash/ash_chromeos_string...
ash/ash_chromeos_strings.grdp:443: Mirroring with more than 3 displays is not
supported.
On 2016/05/06 16:03:50, stevenjb wrote:
> Is the limit displays <= 2, or displays <= 3 ? If it is <= 2 this should say:
> 
> Mirroring with more than two displays is not supported.
> 
> (Either way spell out the number)

Oops, sorry. That's a typical mistake I make as "more than" sometimes is
translated to "equals or more" in Japanese. Fixed.

https://codereview.chromium.org/1952353003/diff/80001/ash/display/display_uti...
File ash/display/display_util.cc (right):

https://codereview.chromium.org/1952353003/diff/80001/ash/display/display_uti...
ash/display/display_util.cc:468: for
(message_center::NotificationList::Notifications::const_iterator iter =
On 2016/05/06 16:03:51, stevenjb wrote:
> nit: for (const auto iter : notifications)
> 

Done.

[oshima, 2016-05-06 18:47:21]

Description was changed from

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
==========

to

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit tests
==========

[oshima, 2016-05-06 18:47:29]

Description was changed from

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit tests
==========

to

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit test
==========

[stevenjb, 2016-05-06 19:30:31]

lgtm

[oshima, 2016-05-06 19:30:49]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-05-06 19:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952353003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952353003/100001

[commit-bot: I haz the power, 2016-05-06 20:19:04]

Description was changed from

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit test
==========

to

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit test
==========

[commit-bot: I haz the power, 2016-05-06 20:19:06]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-05-06 20:20:24]

Description was changed from

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit test
==========

to

==========
Show message to indicate that mirriring with more than 3 display is not
supported.

BUG=608027
TEST=covered by unit test

Committed: https://crrev.com/211a822288a0346b72182cd57d075787777ddc33
Cr-Commit-Position: refs/heads/master@{#392136}
==========

[commit-bot: I haz the power, 2016-05-06 20:20:25]

Patchset 2 (id:??) landed as
https://crrev.com/211a822288a0346b72182cd57d075787777ddc33
Cr-Commit-Position: refs/heads/master@{#392136}