Initial commit of our new Android app to demo Skia.

Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952323004

Committed: https://skia.googlesource.com/skia/+/796c5bb4655a511553970e111c96d90963fb9ae4

[liyuqian, 2016-05-06 16:16:24]

Description was changed from

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
==========

to

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-05-06 16:21:58]

Description was changed from

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[liyuqian, 2016-05-06 16:21:58]

liyuqian@google.com changed reviewers:
+ djsollen@google.com, jvanverth@google.com

[jvanverth1, 2016-05-06 17:02:07]

I defer to Derek for most of this. Just a couple of things I noticed:

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/Window_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.h:51: bool nativeWindowInitialized =
false;
We start member variables with 'f', so this should be fNativeWindowInitialized.
The others above it should be changed, too (which may be my fault).

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:33: pthread_t thread;
Again: fThread, fPipes, etc.

[djsollen, 2016-05-06 18:45:26]

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File platform_tools/android/apps/viewer/build.gradle (right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:25: compile
'com.android.support:appcompat-v7:19.+'
why do we need the support library?  What features are we using from it?

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File platform_tools/android/apps/viewer/src/main/AndroidManifest.xml (right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/AndroidManifest.xml:10:
android:theme="@style/Theme.AppCompat.Light"
I think you can use a standard theme like @android:style/Theme.Holo.Light.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/MainActivity.java
(right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/MainActivity.java:4:
import android.support.v7.app.ActionBarActivity;
This class has been deprecated and I don't think we need to use it since we can
use the actionbar directly.

https://developer.android.com/reference/android/app/ActionBar.html

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/MainActivity.java:27:
mNativeHandle = ((ViewerApplication) getApplication()).getNativeHandle();
don't store this variable locally when you can just look it up when you need it.
 create a private helper called getNativeAppHandle() and use that where you
currently use mNativeHandle.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java
(right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java:1:
package org.skia.viewer;
all the new files need a copyright header.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File platform_tools/android/bin/android_gdb_app (right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/bin/android_gdb_app:13: ACTIVITY="MainActivity"
checking in this change means we can no longer debugger the existing sampleApp. 
I'm fine making this general purpose, but lets break this out into its own CL.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/Window_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.h:11: #include
<android_native_app_glue.h>
remove this and all references to android_app*

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.h:21: APP_CMD_INVAL_WINDOW = 64,
make this on of the MessageTypes in the surface glue.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:16: #include
<android_native_app_glue.h>
we should not need this include.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:30: void* pthread_main(void*
arg);
we don't need to expose this outside the cpp file. I would like to expose an
extern function like the one below that clients implement to fill in their
function pointers.

extern skia_android_main(struct skia_android_app* app);

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:32: struct AppThread {
let's call it something more generic skia_android_app

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:33: pthread_t thread;
make datastructures like fThread private.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:38: 
add a function pointer here that look something like this...

void (*onAppCmd)(struct skia_android_app* app, int32_t cmd);

[djsollen, 2016-05-06 18:58:53]

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:30: void* pthread_main(void*
arg);
On 2016/05/06 18:45:26, djsollen wrote:
> we don't need to expose this outside the cpp file. I would like to expose an
> extern function like the one below that clients implement to fill in their
> function pointers.
> 
> extern skia_android_main(struct skia_android_app* app);

Ignore this comment.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:38: 
On 2016/05/06 18:45:26, djsollen wrote:
> add a function pointer here that look something like this...
> 
> void (*onAppCmd)(struct skia_android_app* app, int32_t cmd);

Ignore this comment.

[liyuqian, 2016-05-06 20:42:30]

Cleaned up a lot of things according to your helpful comments :)

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File platform_tools/android/apps/viewer/build.gradle (right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:25: compile
'com.android.support:appcompat-v7:19.+'
On 2016/05/06 18:45:26, djsollen wrote:
> why do we need the support library?  What features are we using from it?

ActionBarActivity. But since it's deprecated (as you suggested), I should remove
it. I think this problem is caused by my ancient Android Studio version...

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:25: compile
'com.android.support:appcompat-v7:19.+'
On 2016/05/06 18:45:26, djsollen wrote:
> why do we need the support library?  What features are we using from it?

Done.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File platform_tools/android/apps/viewer/src/main/AndroidManifest.xml (right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/AndroidManifest.xml:10:
android:theme="@style/Theme.AppCompat.Light"
On 2016/05/06 18:45:26, djsollen wrote:
> I think you can use a standard theme like @android:style/Theme.Holo.Light.

Done.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/MainActivity.java
(right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/MainActivity.java:4:
import android.support.v7.app.ActionBarActivity;
On 2016/05/06 18:45:26, djsollen wrote:
> This class has been deprecated and I don't think we need to use it since we
can
> use the actionbar directly.
> 
> https://developer.android.com/reference/android/app/ActionBar.html

Done.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/MainActivity.java:27:
mNativeHandle = ((ViewerApplication) getApplication()).getNativeHandle();
On 2016/05/06 18:45:26, djsollen wrote:
> don't store this variable locally when you can just look it up when you need
it.
>  create a private helper called getNativeAppHandle() and use that where you
> currently use mNativeHandle.

Done.

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
File
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java
(right):

https://codereview.chromium.org/1952323004/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java:1:
package org.skia.viewer;
On 2016/05/06 18:45:26, djsollen wrote:
> all the new files need a copyright header.

Done.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/Window_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.h:11: #include
<android_native_app_glue.h>
On 2016/05/06 18:45:26, djsollen wrote:
> remove this and all references to android_app*

Done.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.h:21: APP_CMD_INVAL_WINDOW = 64,
On 2016/05/06 18:45:26, djsollen wrote:
> make this on of the MessageTypes in the surface glue.

Done.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/Window_android.h:51: bool nativeWindowInitialized =
false;
On 2016/05/06 17:02:07, jvanverth1 wrote:
> We start member variables with 'f', so this should be
fNativeWindowInitialized.
> The others above it should be changed, too (which may be my fault).

Done.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:16: #include
<android_native_app_glue.h>
On 2016/05/06 18:45:26, djsollen wrote:
> we should not need this include.

This is needed for LOOPER_ID_USER

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:32: struct AppThread {
On 2016/05/06 18:45:26, djsollen wrote:
> let's call it something more generic skia_android_app

Done.

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:33: pthread_t thread;
On 2016/05/06 17:02:07, jvanverth1 wrote:
> Again: fThread, fPipes, etc.

Done.

[djsollen, 2016-05-09 13:17:14]

looking good.  Just a few more cleanups and we'll need to add the basic input
event handling so that we can reach feature parity with the current
implementation.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
File tools/viewer/sk_app/android/Window_android.cpp (right):

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.cpp:23: bool
Window_android::init(SkiaAndroidApp* skiaAndroidApp) {
can you make this part of the window's constructor and remove this method?

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.cpp:60: void Window_android::inval()
{ paintIfNeeded(); }
you need to post a message here to return control to the UI thread.  This
prevents the device from receiving input events if the content is animating.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
File tools/viewer/sk_app/android/Window_android.h (right):

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.h:31: void paintIfNeeded();
remove this method.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.h:40: SkRect mContentRect;
fContentRect and fSampleCount

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.h:42: bool fNativeWindowInitialized =
false;
make this a field on SkiaAndroidApp

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/surface_glue_android.h:20: enum MessageType {
kUndefined, kSurfaceCreated, kSurfaceChanged, kSurfaceDestroyed, kDestroyApp };
you'll need to add something like... kContentInvalidated so that you can post a
message to yourself to redraw when the window's invalidate method is called.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/surface_glue_android.h:39: void readMessage(Message*
message);
add method paintIfNeeded() that checks to make sure their is an fNativeWindow
and if so calls fWindow->onPaint();

[djsollen, 2016-05-09 13:29:44]

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:16: #include
<android_native_app_glue.h>
On 2016/05/06 20:42:30, liyuqian wrote:
> On 2016/05/06 18:45:26, djsollen wrote:
> > we should not need this include.
> 
> This is needed for LOOPER_ID_USER

you don't need LOOPER_ID_USER as that was something specific to
android_native_app_glue.  You only have one looper so you can replace the line
below with 

static const int LOOPER_ID_USER = 1;

[liyuqian, 2016-05-09 14:27:28]

Revised except Window_android::init (please see the replied comment).

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1952323004/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:16: #include
<android_native_app_glue.h>
On 2016/05/09 13:29:44, djsollen wrote:
> On 2016/05/06 20:42:30, liyuqian wrote:
> > On 2016/05/06 18:45:26, djsollen wrote:
> > > we should not need this include.
> > 
> > This is needed for LOOPER_ID_USER
> 
> you don't need LOOPER_ID_USER as that was something specific to
> android_native_app_glue.  You only have one looper so you can replace the line
> below with 
> 
> static const int LOOPER_ID_USER = 1;

Done.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
File tools/viewer/sk_app/android/Window_android.cpp (right):

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.cpp:23: bool
Window_android::init(SkiaAndroidApp* skiaAndroidApp) {
On 2016/05/09 13:17:14, djsollen wrote:
> can you make this part of the window's constructor and remove this method?

I can't (and I believe that you couldn't either so you added this function in
your earlier code). The reason is that fSkiaAndroidApp is a private field of
Window_android, which couldn't be accessed from Window::CreateNativeWindow.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.cpp:60: void Window_android::inval()
{ paintIfNeeded(); }
On 2016/05/09 13:17:14, djsollen wrote:
> you need to post a message here to return control to the UI thread.  This
> prevents the device from receiving input events if the content is animating.

Done.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
File tools/viewer/sk_app/android/Window_android.h (right):

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.h:31: void paintIfNeeded();
On 2016/05/09 13:17:14, djsollen wrote:
> remove this method.

Done.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.h:40: SkRect mContentRect;
On 2016/05/09 13:17:14, djsollen wrote:
> fContentRect and fSampleCount

Done.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/Window_android.h:42: bool fNativeWindowInitialized =
false;
On 2016/05/09 13:17:14, djsollen wrote:
> make this a field on SkiaAndroidApp

This field is no longer needed as we moved paintIfNeeded to SkiaAndroidApp. It's
sufficient to check that fNativeWindow exists.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/surface_glue_android.h:20: enum MessageType {
kUndefined, kSurfaceCreated, kSurfaceChanged, kSurfaceDestroyed, kDestroyApp };
On 2016/05/09 13:17:14, djsollen wrote:
> you'll need to add something like... kContentInvalidated so that you can post
a
> message to yourself to redraw when the window's invalidate method is called.

Done.

https://codereview.chromium.org/1952323004/diff/100001/tools/viewer/sk_app/an...
tools/viewer/sk_app/android/surface_glue_android.h:39: void readMessage(Message*
message);
On 2016/05/09 13:17:14, djsollen wrote:
> add method paintIfNeeded() that checks to make sure their is an fNativeWindow
> and if so calls fWindow->onPaint();

Done.

[djsollen, 2016-05-09 14:36:22]

lgtm, but you'll need to have a follow on CL to add back in event handling
because the app isn't very useful if we can't switch slides. :)

[liyuqian, 2016-05-09 14:50:26]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-05-09 14:50:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952323004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952323004/120001

[commit-bot: I haz the power, 2016-05-09 14:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 14:52:05]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[liyuqian, 2016-05-09 15:20:29]

I've merged 1950983007 into this CL. I wonder whether we should write a build
trybot for this Android app to avoid potential build break?

[liyuqian, 2016-05-09 15:22:36]

liyuqian@google.com changed reviewers:
+ brianosman@google.com

[liyuqian, 2016-05-09 15:24:47]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 15:24:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952323004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952323004/140001

[liyuqian, 2016-05-09 15:31:58]

The CQ bit was unchecked by liyuqian@google.com

[liyuqian, 2016-05-09 15:31:59]

The CQ bit was checked by liyuqian@google.com

[liyuqian, 2016-05-09 15:31:59]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1952323004/#ps140001
(title: "Merge")

[liyuqian, 2016-05-09 15:32:01]

The CQ bit was unchecked by liyuqian@google.com

[liyuqian, 2016-05-09 15:32:33]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-05-09 15:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952323004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952323004/140001

[commit-bot: I haz the power, 2016-05-09 15:49:33]

Description was changed from

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/796c5bb4655a511553970e111c96d90963fb9ae4
==========

[commit-bot: I haz the power, 2016-05-09 15:49:34]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/796c5bb4655a511553970e111c96d90963fb9ae4

[liyuqian, 2016-05-09 16:45:52]

Description was changed from

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.  Note that the old NativeApplication-based
Activity (ViewerActivity) is still there for reference and test purposes. It
will be removed eventually.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/796c5bb4655a511553970e111c96d90963fb9ae4
==========

to

==========
Initial commit of our new Android app to demo Skia.

Currently, there's only a simple Activity with a title bar and a surface view
that connects with Skia viewer native application.

Before integrating user action events, I want to make sure that the design and
implementation so far are good.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/796c5bb4655a511553970e111c96d90963fb9ae4
==========