Convert tracklist-* tests to testharness.js

Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/95fdf685b3c3f655c4b5d4ab7cd7435d91f8e055
Cr-Commit-Position: refs/heads/master@{#392585}

[Srirama, 2016-05-06 10:05:24]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=
==========

[Srirama, 2016-05-06 10:05:40]

Description was changed from

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=
==========

to

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=
==========

[Srirama, 2016-05-06 10:06:08]

Description was changed from

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=
==========

to

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-05-06 10:14:47]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-05-06 10:24:24]

srirama.m@samsung.com changed reviewers:
+ mlamouri@chromium.org

[Srirama, 2016-05-06 10:24:24]

PTAL

[mlamouri (slow - plz ping), 2016-05-09 12:51:06]

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html
(right):

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:2:
<title>Ensure that a TrackList won't be collected if it has custom
properties.</title>
s/collected/garbage collected/

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:26: });
I really don't see the point of this test... It doesn't quite do what it says
because I don't think we would gc the track even without `myProperty`: it is
held alive by <video>.

What happens if you remove the line setting `myProperty`?

[Srirama, 2016-05-09 13:14:31]

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html
(right):

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:2:
<title>Ensure that a TrackList won't be collected if it has custom
properties.</title>
On 2016/05/09 12:51:05, Mounir Lamouri wrote:
> s/collected/garbage collected/

Acknowledged.

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:26: });
On 2016/05/09 12:51:05, Mounir Lamouri wrote:
> I really don't see the point of this test... It doesn't quite do what it says
> because I don't think we would gc the track even without `myProperty`: it is
> held alive by <video>.
> 
> What happens if you remove the line setting `myProperty`?

You are right, even by removing that there is no change in the test result. So
should we keep this test for now by removing those lines, with a TODO to
investigate more? WDYT?

[mlamouri (slow - plz ping), 2016-05-10 09:08:28]

lgtm with the test deleted.

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html
(right):

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:26: });
On 2016/05/09 at 13:14:31, Srirama wrote:
> On 2016/05/09 12:51:05, Mounir Lamouri wrote:
> > I really don't see the point of this test... It doesn't quite do what it
says
> > because I don't think we would gc the track even without `myProperty`: it is
> > held alive by <video>.
> > 
> > What happens if you remove the line setting `myProperty`?
> 
> You are right, even by removing that there is no change in the test result. So
should we keep this test for now by removing those lines, with a TODO to
investigate more? WDYT?

I think you can delete this test. It doesn't do anything useful.

[Srirama, 2016-05-10 09:46:05]

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html
(right):

https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:26: });
On 2016/05/10 09:08:28, Mounir Lamouri wrote:
> On 2016/05/09 at 13:14:31, Srirama wrote:
> > On 2016/05/09 12:51:05, Mounir Lamouri wrote:
> > > I really don't see the point of this test... It doesn't quite do what it
> says
> > > because I don't think we would gc the track even without `myProperty`: it
is
> > > held alive by <video>.
> > > 
> > > What happens if you remove the line setting `myProperty`?
> > 
> > You are right, even by removing that there is no change in the test result.
So
> should we keep this test for now by removing those lines, with a TODO to
> investigate more? WDYT?
> 
> I think you can delete this test. It doesn't do anything useful.

Done.

[Srirama, 2016-05-10 09:46:13]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-05-10 09:46:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1952323003/#ps40001
(title: "deleted tracklist-is-reachable.html as it is not useful")

[commit-bot: I haz the power, 2016-05-10 09:46:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952323003/40001

[commit-bot: I haz the power, 2016-05-10 12:43:08]

Description was changed from

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-05-10 12:43:09]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-10 12:45:12]

Description was changed from

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert tracklist-* tests to testharness.js

Cleaning up tracklist-* tests in media/track to use testharness.js instead of
video-test.js. This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/95fdf685b3c3f655c4b5d4ab7cd7435d91f8e055
Cr-Commit-Position: refs/heads/master@{#392585}
==========

[commit-bot: I haz the power, 2016-05-10 12:45:13]

Patchset 2 (id:??) landed as
https://crrev.com/95fdf685b3c3f655c4b5d4ab7cd7435d91f8e055
Cr-Commit-Position: refs/heads/master@{#392585}