Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1952323003: Convert tracklist-* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert tracklist-* tests to testharness.js Cleaning up tracklist-* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/95fdf685b3c3f655c4b5d4ab7cd7435d91f8e055 Cr-Commit-Position: refs/heads/master@{#392585}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : deleted tracklist-is-reachable.html as it is not useful #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -110 lines) Patch
M third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable-no-crash.html View 1 chunk +24 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable-no-crash-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-06 10:24:24 UTC) #6
mlamouri (slow - plz ping)
https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html (right): https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html#newcode2 third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:2: <title>Ensure that a TrackList won't be collected if it ...
4 years, 7 months ago (2016-05-09 12:51:06 UTC) #7
Srirama
https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html (right): https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html#newcode2 third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:2: <title>Ensure that a TrackList won't be collected if it ...
4 years, 7 months ago (2016-05-09 13:14:31 UTC) #8
mlamouri (slow - plz ping)
lgtm with the test deleted. https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html (right): https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html#newcode26 third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:26: }); On 2016/05/09 at ...
4 years, 7 months ago (2016-05-10 09:08:28 UTC) #9
Srirama
https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html File third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html (right): https://codereview.chromium.org/1952323003/diff/20001/third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html#newcode26 third_party/WebKit/LayoutTests/media/track/tracklist-is-reachable.html:26: }); On 2016/05/10 09:08:28, Mounir Lamouri wrote: > On ...
4 years, 7 months ago (2016-05-10 09:46:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952323003/40001
4 years, 7 months ago (2016-05-10 09:46:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-10 12:43:09 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 12:45:13 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95fdf685b3c3f655c4b5d4ab7cd7435d91f8e055
Cr-Commit-Position: refs/heads/master@{#392585}

Powered by Google App Engine
This is Rietveld 408576698