Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1952303005: Remove Sk(Float|Double)PinToFixed functions, only used in tests. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove Sk(Float|Double)PinToFixed functions, only used in tests. These were triggering compile-time floating point overflow for one user, and we don't use them. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1952303005 Committed: https://skia.googlesource.com/skia/+/14f850abfe791484f830bd7003811320ee21dcbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M include/private/SkFixed.h View 3 chunks +0 lines, -24 lines 0 comments Download
M tests/MathTest.cpp View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952303005/1
4 years, 7 months ago (2016-05-06 18:24:53 UTC) #3
Brian Osman
4 years, 7 months ago (2016-05-06 18:25:15 UTC) #5
reed1
lgtm
4 years, 7 months ago (2016-05-06 18:26:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952303005/1
4 years, 7 months ago (2016-05-06 18:26:52 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 18:45:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/14f850abfe791484f830bd7003811320ee21dcbb

Powered by Google App Engine
This is Rietveld 408576698