Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1952303002: cc: fix nullptr deref in software renderer. (Closed)

Created:
4 years, 7 months ago by Stephen White
Modified:
4 years, 7 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: fix nullptr deref in software renderer. Check for an empty result rect (which should render nothing) and a null filter (which should render the primitive unfiltered) independently. BUG=609381 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d67155a66c554ec8cba4fc0f0f686847ddb34afd Cr-Commit-Position: refs/heads/master@{#391903}

Patch Set 1 #

Patch Set 2 : Add missing test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M cc/output/software_renderer.cc View 2 chunks +21 lines, -10 lines 0 comments Download
A cc/test/data/white.png View 1 Binary file 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Stephen White
enne: PTAL. Thanks!
4 years, 7 months ago (2016-05-05 19:21:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952303002/1
4 years, 7 months ago (2016-05-05 19:22:11 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952303002/20001
4 years, 7 months ago (2016-05-05 19:29:30 UTC) #9
enne (OOO)
lgtm
4 years, 7 months ago (2016-05-05 19:46:08 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 21:12:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952303002/20001
4 years, 7 months ago (2016-05-05 21:14:24 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 21:32:59 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 21:35:04 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d67155a66c554ec8cba4fc0f0f686847ddb34afd
Cr-Commit-Position: refs/heads/master@{#391903}

Powered by Google App Engine
This is Rietveld 408576698