Use a utils.TempDir() decorator for temporary files, to make sure we clean up even in case of excep…

editor/build/build.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import glob
 import optparse
 import os
 import re
@@ skipping 226 matching lines @@
 
   os.chdir(buildpath)
   ant_property_file = None
   sdk_zip = None
 
   try:
     ant_property_file = tempfile.NamedTemporaryFile(suffix='.property',
                                                     prefix='AntProperties',
                                                     delete=False)
     ant_property_file.close()
-    extra_artifacts = tempfile.mkdtemp(prefix='ExtraArtifacts')
     ant = AntWrapper(ant_property_file.name, os.path.join(antpath, 'bin'),
                      bzip2libpath)
 
     ant.RunAnt(os.getcwd(), '', '', '', '',
                '', '', buildos, ['-diagnostics'])
 
     parser = BuildOptions()
     (options, args) = parser.parse_args()
     # Determine which targets to build. By default we build the "all" target.
     if args:
@@ skipping 111 matching lines @@
       except:
         BuildStepFailure()
 
     StartBuildStep(builder_name)
 
     if PLUGINS_BUILD:
       status = BuildUpdateSite(ant, revision, builder_name, buildroot, buildout,
                                editorpath, buildos)
       return status
 
-    #tell the ant script where to write the sdk zip file so it can
-    #be expanded later
-    status = ant.RunAnt('.', 'build_rcp.xml', revision, builder_name,
-                        buildroot, buildout, editorpath, buildos,
-                        sdk_zip=sdk_zip,
-                        running_on_bot=running_on_buildbot,
-                        extra_artifacts=extra_artifacts)
-    #the ant script writes a property file in a known location so
-    #we can read it.
-    properties = ReadPropertyFile(buildos, ant_property_file.name)
+    with utils.TempDir('ExtraArtifacts') as extra_artifacts:
+      #tell the ant script where to write the sdk zip file so it can
+      #be expanded later
+      status = ant.RunAnt('.', 'build_rcp.xml', revision, builder_name,
+                          buildroot, buildout, editorpath, buildos,
+                          sdk_zip=sdk_zip,
+                          running_on_bot=running_on_buildbot,
+                          extra_artifacts=extra_artifacts)
+      #the ant script writes a property file in a known location so
+      #we can read it.
+      properties = ReadPropertyFile(buildos, ant_property_file.name)
 
-    if not properties:
-      raise Exception('no data was found in file {%s}' % ant_property_file.name)
-    if status:
-      if properties['build.runtime']:
-        PrintErrorLog(properties['build.runtime'])
-      return status
+      if not properties:
+        raise Exception('no data was found in file {%s}'
+                        % ant_property_file.name)
+      if status:
+        if properties['build.runtime']:
+          PrintErrorLog(properties['build.runtime'])
+        return status
 
-    #For the dart-editor build, return at this point.
-    #We don't need to install the sdk+dartium, run tests, or copy to google
-    #storage.
-    if not buildos:
-      print 'skipping sdk and dartium steps for dart-editor build'
+      #For the dart-editor build, return at this point.
+      #We don't need to install the sdk+dartium, run tests, or copy to google
+      #storage.
+      if not buildos:
+        print 'skipping sdk and dartium steps for dart-editor build'
+        return 0
+
+      #This is an override for local testing
+      force_run_install = os.environ.get('FORCE_RUN_INSTALL')
+
+      if force_run_install or (not PLUGINS_BUILD):
+        InstallSdk(buildroot, buildout, buildos, buildout)
+        InstallDartium(buildroot, buildout, buildos, gsu)
+
+      if status:
+        return status
+
+      if not build_skip_tests:
+        RunEditorTests(buildout, buildos)
+
+      if buildos:
+        StartBuildStep('upload_artifacts')
+
+        _InstallArtifacts(buildout, buildos, extra_artifacts)
+
+        # dart-editor-linux.gtk.x86.zip --> darteditor-linux-32.zip
+        RenameRcpZipFiles(buildout)
+
+        PostProcessEditorBuilds(buildout)
+
+        if running_on_buildbot:
+          version_file = _FindVersionFile(buildout)
+          if version_file:
+            UploadFile(version_file, False)
+
+          found_zips = _FindRcpZipFiles(buildout)
+          for zipfile in found_zips:
+            UploadFile(zipfile)
+
       return 0
-
-    #This is an override for local testing
-    force_run_install = os.environ.get('FORCE_RUN_INSTALL')
-
-    if force_run_install or (not PLUGINS_BUILD):
-      InstallSdk(buildroot, buildout, buildos, buildout)
-      InstallDartium(buildroot, buildout, buildos, gsu)
-
-    if status:
-      return status
-
-    if not build_skip_tests:
-      RunEditorTests(buildout, buildos)
-
-    if buildos:
-      StartBuildStep('upload_artifacts')
-
-      _InstallArtifacts(buildout, buildos, extra_artifacts)
-
-      # dart-editor-linux.gtk.x86.zip --> darteditor-linux-32.zip
-      RenameRcpZipFiles(buildout)
-
-      PostProcessEditorBuilds(buildout)
-
-      if running_on_buildbot:
-        version_file = _FindVersionFile(buildout)
-        if version_file:
-          UploadFile(version_file, False)
-
-        found_zips = _FindRcpZipFiles(buildout)
-        for zipfile in found_zips:
-          UploadFile(zipfile)
-
-    return 0
   finally:
     if ant_property_file is not None:
       print 'cleaning up temp file {0}'.format(ant_property_file.name)
       os.remove(ant_property_file.name)
-    if extra_artifacts:
-      print 'cleaning up temp dir {0}'.format(extra_artifacts)
-      shutil.rmtree(extra_artifacts)
     print 'cleaning up {0}'.format(buildroot)
     shutil.rmtree(buildroot, True)
     print 'Build Done'
 
 
 def ReadPropertyFile(buildos, property_file):
   """Read a property file and return a dictionary of key/value pairs.
 
   Args:
     buildos: the os the build is running under
@@ skipping 309 matching lines @@
     f.write('%s *%s' % (checksum, os.path.basename(filename)))
 
   return checksum_filename
 
 
 def RunEditorTests(buildout, buildos):
   StartBuildStep('run_tests')
 
   for editorArchive in _FindRcpZipFiles(buildout):
     if (editorArchive.endswith('_64.zip')):
-      print 'Running tests for %s...' % editorArchive
-      tempDir = tempfile.mkdtemp(prefix='editor_')
-      
-      zipper = ziputils.ZipUtil(join(buildout, editorArchive), buildos)
-      zipper.UnZip(tempDir)
+      with utils.TempDir('editor_') as tempDir:
+        print 'Running tests for %s...' % editorArchive
 
-      editorExecutable = GetEditorExecutable(join(tempDir, 'dart'))
-      args = [editorExecutable, '-consoleLog', '--test', '--auto-exit',
-              '-data', join(tempDir, 'workspace')]
-      if sys.platform == 'linux':
-        args = ['xvfb-run', '-a'] + args
-      if (subprocess.call(args, shell=IsWindows())):
-        BuildStepFailure()
+        zipper = ziputils.ZipUtil(join(buildout, editorArchive), buildos)
+        zipper.UnZip(tempDir)
 
-      shutil.rmtree(tempDir, True)
+        editorExecutable = GetEditorExecutable(join(tempDir, 'dart'))
+        args = [editorExecutable, '-consoleLog', '--test', '--auto-exit',
+                '-data', join(tempDir, 'workspace')]
+        if sys.platform == 'linux':
+          args = ['xvfb-run', '-a'] + args
+        if (subprocess.call(args, shell=IsWindows())):
+          BuildStepFailure()
 
 
 def GetEditorExecutable(editorDir):
   if sys.platform == 'darwin':
     executable = join('DartEditor.app', 'Contents', 'MacOS', 'DartEditor')
   elif sys.platform == 'win32':
     executable = 'DartEditor.exe'
   else:
     executable = 'DartEditor'
   return join(editorDir, executable)
@@ skipping 280 matching lines @@
   """delete the given file - do not re-throw any exceptions that occur"""
   if os.path.exists(f):
     try:
       os.remove(f)
     except OSError:
       print 'error deleting %s' % f
 
 
 if __name__ == '__main__':
   sys.exit(main())