Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1952283004:
DevTools: fix incorrect device orientation bug (Closed)
|
Created:
4 years, 7 months ago by luoe Modified:
4 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: fix incorrect device orientation bug
BUG=609665
Committed: https://crrev.com/a5245f4b17a4e98b11105fe904f3f3bce3153c2b
Cr-Commit-Position: refs/heads/master@{#392500}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove unnecessary webkit prefixes #Patch Set 3 : Renaming matrix function #Patch Set 4 : Clean up logic #
Messages
Total messages: 23 (10 generated)
Description was changed from ========== DevTools: fix incorrect device orientation bug BUG=604833 ========== to ========== DevTools: fix incorrect device orientation bug BUG=609665 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
This is my fault. The preview and actual orientation are off by 90 degrees! This corrects the shift.
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952283004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/1952283004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js (right): https://codereview.chromium.org/1952283004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:364: this._boxElement.style.webkitTransform = this._currentMatrix; let's use transform here
luoe@chromium.org changed reviewers: + phistuck@gmail.com
I've removed the webkit prefixes on transform and linear-gradient, and renamed the screenSpaceMatrix() to a clearer(?) name: viewportPreviewMatrix(). https://codereview.chromium.org/1952283004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js (right): https://codereview.chromium.org/1952283004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:364: this._boxElement.style.webkitTransform = this._currentMatrix; On 2016/05/06 18:04:47, lushnikov wrote: > let's use transform here Done.
Great, thank you!
I found out that some of the rotations were incorrect, and adjusted them accordingly. Ready for review, thanks!
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952283004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952283004/60001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952283004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952283004/60001
Message was sent while issue was closed.
Description was changed from ========== DevTools: fix incorrect device orientation bug BUG=609665 ========== to ========== DevTools: fix incorrect device orientation bug BUG=609665 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: fix incorrect device orientation bug BUG=609665 ========== to ========== DevTools: fix incorrect device orientation bug BUG=609665 Committed: https://crrev.com/a5245f4b17a4e98b11105fe904f3f3bce3153c2b Cr-Commit-Position: refs/heads/master@{#392500} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/a5245f4b17a4e98b11105fe904f3f3bce3153c2b Cr-Commit-Position: refs/heads/master@{#392500} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
