Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952253004: I18nBehavior: make i18nRaw private as raw_, add tests (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
tommycli, Moe
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@i18n-behavior
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

I18nBehavior: make i18nRaw private as raw_, add tests R=mahmadi@chromium.org BUG=605226 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d70d9aaff0a51af4e69674be5ad9aaac07230b4a Cr-Commit-Position: refs/heads/master@{#392192}

Patch Set 1 : git add #

Patch Set 2 : asdf #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
A chrome/test/data/webui/i18n_behavior_test.html View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/webui/resources/js/i18n_behavior.js View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Dan Beam
4 years, 7 months ago (2016-05-06 20:09:52 UTC) #2
Moe
On 2016/05/06 20:09:52, Dan Beam wrote: lgtm Out of curiosity though, why changing the signature ...
4 years, 7 months ago (2016-05-06 20:32:28 UTC) #4
Dan Beam
On 2016/05/06 20:32:28, Moe wrote: > On 2016/05/06 20:09:52, Dan Beam wrote: > > lgtm ...
4 years, 7 months ago (2016-05-06 21:00:58 UTC) #5
Dan Beam
On 2016/05/06 21:00:58, Dan Beam wrote: > On 2016/05/06 20:32:28, Moe wrote: > > On ...
4 years, 7 months ago (2016-05-06 21:02:19 UTC) #6
Dan Beam
+tommycli@ for committer stamp
4 years, 7 months ago (2016-05-06 21:03:12 UTC) #8
tommycli
lgtm sans below https://codereview.chromium.org/1952253004/diff/40001/chrome/test/data/webui/i18n_behavior_test.html File chrome/test/data/webui/i18n_behavior_test.html (right): https://codereview.chromium.org/1952253004/diff/40001/chrome/test/data/webui/i18n_behavior_test.html#newcode2 chrome/test/data/webui/i18n_behavior_test.html:2: <script> The html and body tags ...
4 years, 7 months ago (2016-05-06 21:10:57 UTC) #9
Dan Beam
https://codereview.chromium.org/1952253004/diff/40001/chrome/test/data/webui/i18n_behavior_test.html File chrome/test/data/webui/i18n_behavior_test.html (right): https://codereview.chromium.org/1952253004/diff/40001/chrome/test/data/webui/i18n_behavior_test.html#newcode2 chrome/test/data/webui/i18n_behavior_test.html:2: <script> On 2016/05/06 21:10:57, tommycli wrote: > The html ...
4 years, 7 months ago (2016-05-06 21:43:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952253004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952253004/60001
4 years, 7 months ago (2016-05-06 21:44:00 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-06 22:51:56 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 22:54:12 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d70d9aaff0a51af4e69674be5ad9aaac07230b4a
Cr-Commit-Position: refs/heads/master@{#392192}

Powered by Google App Engine
This is Rietveld 408576698