Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1952223006: Update String.fromCharCodes from sdk (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -45 lines) Patch
M lib/runtime/dart_sdk.js View 6 chunks +38 lines, -18 lines 0 comments Download
M tool/input_sdk/lib/core/core.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 3 chunks +23 lines, -18 lines 0 comments Download
M tool/input_sdk/patch/internal_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/js_helper.dart View 2 chunks +20 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
Committed patchset #1 (id:1) manually as 941f93a464bd197e8f2c71398701f68c68311a3c (presubmit successful).
4 years, 7 months ago (2016-05-06 03:52:39 UTC) #2
vsm
4 years, 7 months ago (2016-05-06 13:14:11 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698