Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1952213005: [Media Router WebUI] Fix remaining AX_COLOR_01 warnings. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix remaining AX_COLOR_01 warnings. This change makes: - non-blocking issue button text lighter blue. - blocking issue header background darker red. - cast mode view header background darker teal. BUG=609167 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/01a6592cf9703eac1ec9a156efe4d1bc5470b019 Cr-Commit-Position: refs/heads/master@{#392123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks! Screenshots are really blurry from remoting from a chromebox, but let me know ...
4 years, 7 months ago (2016-05-05 17:33:22 UTC) #4
imcheng
lgtm
4 years, 7 months ago (2016-05-06 18:15:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952213005/1
4 years, 7 months ago (2016-05-06 18:32:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 19:32:26 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:34:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01a6592cf9703eac1ec9a156efe4d1bc5470b019
Cr-Commit-Position: refs/heads/master@{#392123}

Powered by Google App Engine
This is Rietveld 408576698