👪 Strip R.class in android_prebuilt()

Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576
Committed: https://crrev.com/dd2adf0e9718ec28f46dde4c09e379c9df82065e
Cr-Commit-Position: refs/heads/master@{#392620}

[agrieve, 2016-05-05 01:44:56]

Description was changed from

==========
Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576
==========

to

==========
Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576
==========

[agrieve, 2016-05-05 01:44:56]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2016-05-05 01:45:03]

On 2016/05/05 01:44:56, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:yfriedman@chromium.org

[Yaron, 2016-05-06 15:26:04]

lgtm - seems reasonable

[agrieve, 2016-05-06 15:41:56]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-05-06 15:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952153002/1

[commit-bot: I haz the power, 2016-05-06 16:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 16:14:21]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-05-06 18:37:09]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-05-06 18:37:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952153002/1

[commit-bot: I haz the power, 2016-05-06 19:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 19:13:56]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[agrieve, 2016-05-06 20:19:52]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-05-06 20:20:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952153002/1

[commit-bot: I haz the power, 2016-05-06 20:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 20:54:42]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[agrieve, 2016-05-10 14:57:09]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-05-10 14:57:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1952153002/#ps20001
(title: "Don't strip out *all* R.class, just those associated with known
resources")

[commit-bot: I haz the power, 2016-05-10 14:57:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952153002/20001

[commit-bot: I haz the power, 2016-05-10 15:57:01]

Description was changed from

==========
Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576
==========

to

==========
Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576
==========

[commit-bot: I haz the power, 2016-05-10 15:57:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 15:58:36]

Description was changed from

==========
Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576
==========

to

==========
Strip R.class in android_prebuilt()

Some Android libraries have started including R.class in their jar
files, so they need to be stripped before dexing.

BUG=585576

Committed: https://crrev.com/dd2adf0e9718ec28f46dde4c09e379c9df82065e
Cr-Commit-Position: refs/heads/master@{#392620}
==========

[commit-bot: I haz the power, 2016-05-10 15:58:37]

Patchset 2 (id:??) landed as
https://crrev.com/dd2adf0e9718ec28f46dde4c09e379c9df82065e
Cr-Commit-Position: refs/heads/master@{#392620}

[jbudorick, 2016-05-10 23:24:42]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-05-10 23:24:43]

https://codereview.chromium.org/1952153002/diff/20001/build/android/gyp/jar.py
File build/android/gyp/jar.py (right):

https://codereview.chromium.org/1952153002/diff/20001/build/android/gyp/jar.p...
build/android/gyp/jar.py:79: print excluded_classes
you got your print messages in the build output :(