third_party/WebKit/LayoutTests/fast/table/change-row-border-width.html - Issue 1952133006: [css-tables] Set table and cell widths dirty when row border width changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/change-row-border-width.html

Issue 1952133006: [css-tables] Set table and cell widths dirty when row border width changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/table/change-row-border-width-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTableRow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <style>

	3 td {

	4 width: 50px;

	5 height: 50px;

	6 padding: 0px;

	7 }

	8 </style>

	9 <script src="../../resources/check-layout.js"></script>

	10 <script type="text/javascript">

	11 window.testRunner && window.testRunner.waitUntilDone();

	12 window.addEventListener("load", changeBorderWidthAndCheck);

	13 function changeBorderWidthAndCheck() {

	14 requestAnimationFrame(function() {

	15 document.getElementById("row").style.borderWidth = "4px";

	16 checkLayout("table");

	17 window.testRunner && window.testRunner.notifyDone();
	mstensho (USE GERRIT) 2016/05/09 08:41:53 I wonder if this could be simplified if you instea I wonder if this could be simplified if you instead use runAfterLayoutAndPaint() from ../../resources/run-after-layout-and-paint.js dgrogan 2016/05/16 23:34:16 Beautiful. Done. Show quoted text On 2016/05/09 08:41:53, mstensho wrote: > I wonder if this could be simplified if you instead use runAfterLayoutAndPaint() > from ../../resources/run-after-layout-and-paint.js Beautiful. Done.
	18 });

	19 }

	20 </script>

	21 There should be a square with a 4px blue border.

	22 <table style="border-collapse:collapse" data-expected-width=58>
	mstensho (USE GERRIT) 2016/05/09 08:41:53 Add data-expected-height too? Add data-expected-height too? dgrogan 2016/05/16 23:34:16 Done. Show quoted text On 2016/05/09 08:41:53, mstensho wrote: > Add data-expected-height too? Done.
	23 <tr style="border:18px solid lightblue" id="row">

	24 <td />

	25 </tr>

	26 </table>

OLD	NEW