Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1952133003: WebMediaPlayerImpl now uses OverlayFullscreenVideo mode on Android (Closed)

Created:
4 years, 7 months ago by watk
Modified:
4 years, 7 months ago
CC:
mlamouri (slow - plz ping), whywhat, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebMediaPlayerImpl now uses OverlayFullscreenVideo mode on Android OverlayFullscreenVideo mode was previously only used by WebMediaplayerAndroid, but as we move to using WebMediaPlayerImpl on Android, it's enabled there too. OverlayFullscreenVideo sets the cc root layer to be the video layer and makes the LayerTreeView background transparent. The result is much smoother fullscreen orientation changes. BUG=603521 Committed: https://crrev.com/9c87c6fa459e38528942038abeeba8258ccf1404 Cr-Commit-Position: refs/heads/master@{#392141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M media/blink/webmediaplayer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
watk
4 years, 7 months ago (2016-05-05 23:46:11 UTC) #3
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-05 23:54:45 UTC) #4
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-06 01:24:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952133003/1
4 years, 7 months ago (2016-05-06 01:32:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/217315)
4 years, 7 months ago (2016-05-06 05:29:51 UTC) #10
mlamouri (slow - plz ping)
+avayvod@ FYI
4 years, 7 months ago (2016-05-06 09:04:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952133003/1
4 years, 7 months ago (2016-05-06 19:18:08 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 20:37:04 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 20:39:19 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c87c6fa459e38528942038abeeba8258ccf1404
Cr-Commit-Position: refs/heads/master@{#392141}

Powered by Google App Engine
This is Rietveld 408576698