Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 195213003: Add compile flag to force usage of distance fields for all SkPaints. (Closed)

Created:
6 years, 9 months ago by jvanverth1
Modified:
6 years, 9 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add compile flag to force usage of distance fields for all SkPaints. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=13770

Patch Set 1 #

Patch Set 2 : Activate distance fields in an internal location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/common_variables.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jvanverth1
6 years, 9 months ago (2014-03-11 17:45:13 UTC) #1
jvanverth1
Updated to move the activation point for forced distance fields to be internal.
6 years, 9 months ago (2014-03-11 19:51:52 UTC) #2
robertphillips
I think we will want to run this on our bots so advocate keeping the ...
6 years, 9 months ago (2014-03-11 19:58:06 UTC) #3
reed1
lgtm
6 years, 9 months ago (2014-03-11 19:59:42 UTC) #4
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 9 months ago (2014-03-12 16:10:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/195213003/20001
6 years, 9 months ago (2014-03-12 16:10:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/195213003/20001
6 years, 9 months ago (2014-03-12 16:49:01 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 17:05:49 UTC) #8
Message was sent while issue was closed. 
Change committed as 13770

Powered by Google App Engine
This is Rietveld 408576698