Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1952103002: Fix some WebSocket strong-mode errors and warnings. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M sdk/lib/io/bytes_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/websocket_impl.dart View 7 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 7 months ago (2016-05-05 00:24:20 UTC) #2
Søren Gjesse
lgtm, thanks
4 years, 7 months ago (2016-05-05 03:41:14 UTC) #3
nweiz
4 years, 7 months ago (2016-05-05 17:20:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e41fb4cafd6052157dbc1490d437045240f4773f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698