fix Set::AsArray to not leave undefined holes in output array

fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
LOG=y

Committed: https://crrev.com/2d9bfe9ad5a3a742df57127014b085cbed7f8093
Cr-Commit-Position: refs/heads/master@{#36091}

[jwolfe, 2016-05-04 23:29:38]

Description was changed from

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
==========

to

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
==========

[jwolfe, 2016-05-04 23:29:38]

jwolfe@igalia.com changed reviewers:
+ aklein@chromium.org, caitpotter88@gmail.com

[jwolfe, 2016-05-05 01:25:30]

I think @caitp is right that this is also a problem with Map::AsArray(). Should
I fix that in this CL as well?

[caitp (gmail), 2016-05-06 21:55:13]

caitpotter88@gmail.com changed reviewers:
+ adamk@chromium.org
- aklein@chromium.org

[caitp (gmail), 2016-05-06 21:55:14]

+adamk

[adamk, 2016-05-06 22:01:27]

lgtm. You'll have to add a "LOG=n" line to the CL description to keep the
presubmit from complaining.

[adamk, 2016-05-06 22:01:55]

On 2016/05/06 22:01:27, adamk wrote:
> lgtm. You'll have to add a "LOG=n" line to the CL description to keep the
> presubmit from complaining.

Or maybe LOG=y, since this is an "API change" of sorts.

[jwolfe, 2016-05-06 22:04:36]

Description was changed from

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
==========

to

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
LOG=y
==========

[jwolfe, 2016-05-06 22:37:20]

On 2016/05/06 22:01:55, adamk wrote:
> Or maybe LOG=y, since this is an "API change" of sorts.

done. What's the next step?

[jwolfe, 2016-05-06 22:38:52]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2016-05-06 22:38:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952093002/1

[commit-bot: I haz the power, 2016-05-06 22:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 22:38:59]

The author jwolfe@igalia.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[caitp (gmail), 2016-05-06 22:42:29]

On 2016/05/06 22:38:59, commit-bot: I haz the power wrote:
> The author mailto:jwolfe@igalia.com has not signed Google Contributor License
> Agreement. Please visit https://cla.developers.google.com to sign and manage
> CLA.

add yourself to AUTHORS file, I think. presubmit doesnt talk to the api to
figure out who signed

[jwolfe, 2016-05-07 00:00:31]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2016-05-07 00:00:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952093002/1

[commit-bot: I haz the power, 2016-05-07 00:32:43]

Description was changed from

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
LOG=y
==========

to

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
LOG=y
==========

[commit-bot: I haz the power, 2016-05-07 00:32:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-07 00:33:31]

Description was changed from

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
LOG=y
==========

to

==========
fix Set::AsArray to not leave undefined holes in output array

Add comments explaining how to iterate over an OrderedHashTable.
Use the correct strategy for iteration in Set::AsArray().
Add a DCHECK bounds check in OrderedHashTable::KeyAt().

BUG=v8:4946
LOG=y

Committed: https://crrev.com/2d9bfe9ad5a3a742df57127014b085cbed7f8093
Cr-Commit-Position: refs/heads/master@{#36091}
==========

[commit-bot: I haz the power, 2016-05-07 00:33:32]

Patchset 1 (id:??) landed as
https://crrev.com/2d9bfe9ad5a3a742df57127014b085cbed7f8093
Cr-Commit-Position: refs/heads/master@{#36091}

[adamk, 2016-05-09 20:56:42]

The obvious followup to this would be to fix Map::AsArray; do you have plans to
do so soon? If not I'll probably pick it up.

[jwolfe, 2016-05-09 21:25:50]

On 2016/05/09 20:56:42, adamk wrote:
> The obvious followup to this would be to fix Map::AsArray; do you have plans
to
> do so soon? If not I'll probably pick it up.

I have plenty of things to keep my busy at the moment. I could do it, but it
sounds like you should take care of it instead.

[adamk, 2016-05-09 22:17:56]

On 2016/05/09 21:25:50, jwolfe wrote:
> On 2016/05/09 20:56:42, adamk wrote:
> > The obvious followup to this would be to fix Map::AsArray; do you have plans
> to
> > do so soon? If not I'll probably pick it up.
> 
> I have plenty of things to keep my busy at the moment. I could do it, but it
> sounds like you should take care of it instead.

Ok, sent https://codereview.chromium.org/1965593002/ out for review.