Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952083002: breakpad: fix unittest errors (Closed)

Created:
4 years, 7 months ago by yunlian
Modified:
4 years, 7 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

breakpad: fix unittest errors This fixes the unittest error caused by https://codereview.chromium.org/1884283002/ TEST=unittest passes on falco board in ChromeOS. BUG= R=vapier@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/638066b82e913e681d887e4561d9984e6a3af1c8

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M Makefile.in View 2 chunks +28 lines, -0 lines 0 comments Download
M src/client/linux/handler/exception_handler_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/common/dwarf/dwarf2reader_die_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
vapier
don't take this the wrong way, but didn't you run `make && make check` before ...
4 years, 7 months ago (2016-05-04 23:29:56 UTC) #3
yunlian
4 years, 7 months ago (2016-05-04 23:48:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
638066b82e913e681d887e4561d9984e6a3af1c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698