Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: bench/LineBench.cpp

Issue 1952063005: Revert of Modify LineBench for drawing straight line (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/LineBench.cpp
diff --git a/bench/LineBench.cpp b/bench/LineBench.cpp
index 3127d4efeca5e8078a63c6bf24a27c0f52110713..67dc5648be9db4f83443c9011c195d1e2cbb4472 100644
--- a/bench/LineBench.cpp
+++ b/bench/LineBench.cpp
@@ -21,33 +21,19 @@
bool fDoAA;
SkString fName;
enum {
- LINES = 500,
+ PTS = 500,
};
- SkPoint fStartPts[LINES];
- SkPoint fEndPts[LINES];
+ SkPoint fPts[PTS];
public:
- enum LineType {
- SH, // Straight + horizontally
- SV, // Straight + vertically
- RAND,
- };
- LineBench(SkScalar width, bool doAA, LineType type) {
+ LineBench(SkScalar width, bool doAA) {
fStrokeWidth = width;
fDoAA = doAA;
- fName.printf("lines_%g_%s_%s", width, doAA ? "AA" : "BW",
- type == SH ? "SH" : (type == SV ? "SV" : "RAND"));
+ fName.printf("lines_%g_%s", width, doAA ? "AA" : "BW");
SkRandom rand;
- for (int i = 0; i < LINES; ++i) {
- fStartPts[i].set(rand.nextUScalar1() * 640, rand.nextUScalar1() * 480);
- if (type == SH) {
- fEndPts[i].set(rand.nextUScalar1() * 640, fStartPts[i].y());
- } else if (type == SV) {
- fEndPts[i].set(fStartPts[i].x(), rand.nextUScalar1() * 480);
- } else {
- fEndPts[i].set(rand.nextUScalar1() * 640, rand.nextUScalar1() * 480);
- }
+ for (int i = 0; i < PTS; ++i) {
+ fPts[i].set(rand.nextUScalar1() * 640, rand.nextUScalar1() * 480);
}
}
@@ -65,7 +51,7 @@
paint.setStrokeWidth(fStrokeWidth);
for (int i = 0; i < loops; i++) {
- canvas->drawLine(fStartPts[i].x(), fStartPts[i].y(), fEndPts[i].x(), fEndPts[i].y(), paint);
+ canvas->drawPoints(SkCanvas::kLines_PointMode, PTS, fPts, paint);
}
}
@@ -73,21 +59,8 @@
typedef Benchmark INHERITED;
};
-DEF_BENCH(return new LineBench(0, false, LineBench::SH);)
-DEF_BENCH(return new LineBench(SK_Scalar1, false, LineBench::SH);)
-DEF_BENCH(return new LineBench(0, true, LineBench::SH);)
-DEF_BENCH(return new LineBench(SK_Scalar1/2, true, LineBench::SH);)
-DEF_BENCH(return new LineBench(SK_Scalar1, true, LineBench::SH);)
-DEF_BENCH(return new LineBench(SK_Scalar1*10,true, LineBench::SH);)
-DEF_BENCH(return new LineBench(0, false, LineBench::SV);)
-DEF_BENCH(return new LineBench(SK_Scalar1, false, LineBench::SV);)
-DEF_BENCH(return new LineBench(0, true, LineBench::SV);)
-DEF_BENCH(return new LineBench(SK_Scalar1/2, true, LineBench::SV);)
-DEF_BENCH(return new LineBench(SK_Scalar1, true, LineBench::SV);)
-DEF_BENCH(return new LineBench(SK_Scalar1*10,true, LineBench::SV);)
-DEF_BENCH(return new LineBench(0, false, LineBench::RAND);)
-DEF_BENCH(return new LineBench(SK_Scalar1, false, LineBench::RAND);)
-DEF_BENCH(return new LineBench(0, true, LineBench::RAND);)
-DEF_BENCH(return new LineBench(SK_Scalar1/2, true, LineBench::RAND);)
-DEF_BENCH(return new LineBench(SK_Scalar1, true, LineBench::RAND);)
-DEF_BENCH(return new LineBench(SK_Scalar1*10,true, LineBench::RAND);)
+DEF_BENCH(return new LineBench(0, false);)
+DEF_BENCH(return new LineBench(SK_Scalar1, false);)
+DEF_BENCH(return new LineBench(0, true);)
+DEF_BENCH(return new LineBench(SK_Scalar1/2, true);)
+DEF_BENCH(return new LineBench(SK_Scalar1, true);)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698