Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1952063005: Revert of Modify LineBench for drawing straight line (Closed)

Created:
4 years, 7 months ago by reed1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Modify LineBench for drawing straight line (patchset #3 id:40001 of https://codereview.chromium.org/1936153002/ ) Reason for revert: for (int i = 0; i < loops; i++) { 54 canvas->drawPoints(SkCanvas::kLines_PointMode, PTS, fPts, paint); 68 canvas->drawLine(fStartPts[i].x(), fStartPts[i].y(), fEndPts[i].x(), fEndPts[i].y(), pai nt); This change means we index arbitrarily far into fStartPts (if loops gets big enough). Original issue's description: > Modify LineBench for drawing > > Currently we only have benchmark for lines that contains randomly generated > points. This CL modifies the benchmark which adds cases of drawing straight > lines. Also, this CL changes the call from drawPoints() to drawLines() > which measures the performance of line drawing. > > BUG=skia:5243 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936153002 > > Committed: https://skia.googlesource.com/skia/+/6b27a5e7292d9a18e376f0c229ec62f7b801305a TBR=bsalomon@chromium.org,robertphillips@chromium.org,robertphillips@google.com,xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5243 Committed: https://skia.googlesource.com/skia/+/6c0f5d91e20eacb031e0981ca9841e26d7636a6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -39 lines) Patch
M bench/LineBench.cpp View 3 chunks +12 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of Modify LineBench for drawing straight line
4 years, 7 months ago (2016-05-05 21:02:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952063005/1
4 years, 7 months ago (2016-05-05 21:02:30 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 21:02:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6c0f5d91e20eacb031e0981ca9841e26d7636a6d

Powered by Google App Engine
This is Rietveld 408576698