Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1952043003: Add SSE2/MMX build flags when building on an x86 host. This is necessary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 # Linker warnings. 212 # Linker warnings.
213 if (!(is_chromeos && current_cpu == "arm") && 213 if (!(is_chromeos && current_cpu == "arm") &&
214 !(is_android && use_order_profiling) && !is_mac && !is_ios) { 214 !(is_android && use_order_profiling) && !is_mac && !is_ios) {
215 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580 215 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
216 # TODO(lizeb,pasko): Fix link errors when linking with order_profiling=1 216 # TODO(lizeb,pasko): Fix link errors when linking with order_profiling=1
217 # crbug.com/485542 217 # crbug.com/485542
218 ldflags += [ "-Wl,--fatal-warnings" ] 218 ldflags += [ "-Wl,--fatal-warnings" ]
219 } 219 }
220 } 220 }
221 221
222 if (current_cpu == "x86") {
223 cflags += [
224 "-msse2",
225 "-mfpmath=sse",
226 "-mmmx",
Nico 2016/05/05 17:33:23 doesn't msse2 imply mmx?
saiarcot895 2016/05/05 21:25:18 It might (based on the options for the -march flag
227 ]
228 }
229
222 if (is_clang && is_debug) { 230 if (is_clang && is_debug) {
223 # Allow comparing the address of references and 'this' against 0 231 # Allow comparing the address of references and 'this' against 0
224 # in debug builds. Technically, these can never be null in 232 # in debug builds. Technically, these can never be null in
225 # well-defined C/C++ and Clang can optimize such checks away in 233 # well-defined C/C++ and Clang can optimize such checks away in
226 # release builds, but they may be used in asserts in debug builds. 234 # release builds, but they may be used in asserts in debug builds.
227 cflags_cc += [ 235 cflags_cc += [
228 "-Wno-undefined-bool-conversion", 236 "-Wno-undefined-bool-conversion",
229 "-Wno-tautological-undefined-compare", 237 "-Wno-tautological-undefined-compare",
230 ] 238 ]
231 } 239 }
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1449 1457
1450 if (is_ios || is_mac) { 1458 if (is_ios || is_mac) {
1451 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1459 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1452 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1460 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1453 config("enable_arc") { 1461 config("enable_arc") {
1454 common_flags = [ "-fobjc-arc" ] 1462 common_flags = [ "-fobjc-arc" ]
1455 cflags_objc = common_flags 1463 cflags_objc = common_flags
1456 cflags_objcc = common_flags 1464 cflags_objcc = common_flags
1457 } 1465 }
1458 } 1466 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698