Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952033002: [Android] Disable build/gyp_chromium hook. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
Reviewers:
rmistry, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable build/gyp_chromium hook. BUG= Committed: https://crrev.com/4ec4a8bd6420a2e372b8f4680007b065fca5f3ec Cr-Commit-Position: refs/heads/master@{#391725}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/gyp_chromium.py View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
jbudorick
4 years, 7 months ago (2016-05-04 22:26:35 UTC) #2
agrieve
On 2016/05/04 22:26:35, jbudorick wrote: lgtm
4 years, 7 months ago (2016-05-04 23:53:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952033002/1
4 years, 7 months ago (2016-05-05 00:52:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 01:49:41 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4ec4a8bd6420a2e372b8f4680007b065fca5f3ec Cr-Commit-Position: refs/heads/master@{#391725}
4 years, 7 months ago (2016-05-05 01:51:26 UTC) #8
rmistry
https://codereview.chromium.org/1952033002/diff/1/build/gyp_chromium.py File build/gyp_chromium.py (right): https://codereview.chromium.org/1952033002/diff/1/build/gyp_chromium.py#newcode334 build/gyp_chromium.py:334: print 'or set the environment variable GYP_CHROMIUM_NO_ACTION=0.' These messages ...
4 years, 7 months ago (2016-05-05 14:20:58 UTC) #10
jbudorick
4 years, 7 months ago (2016-05-05 21:17:11 UTC) #11
Message was sent while issue was closed. 
On 2016/05/05 14:20:58, rmistry wrote:
> https://codereview.chromium.org/1952033002/diff/1/build/gyp_chromium.py
> File build/gyp_chromium.py (right):
> 
>
https://codereview.chromium.org/1952033002/diff/1/build/gyp_chromium.py#newco...
> build/gyp_chromium.py:334: print 'or set the environment variable
> GYP_CHROMIUM_NO_ACTION=0.'
> These messages are no longer correct.

This CL wasn't supposed to entirely disable build/gyp_chromium for Android; it
was simply supposed to stop it running as a hook. (i.e., the message _should_ be
correct)

Fixing here: https://codereview.chromium.org/1947423003/

Powered by Google App Engine
This is Rietveld 408576698