Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1952023002: Minor cleanup based on profiler output of CompileParseFunction. (Closed)

Created:
4 years, 7 months ago by siva
Modified:
4 years, 7 months ago
Reviewers:
regis, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Minor cleanup based on profiler output of CompileParseFunction. - Add a zone parameter to TokenStream::Iterator - Add IsXXXX() functions in raw_object.h using GetClassId() - Modify - Function::owner - Function::origin - Type::IsMalformed - Type::IsMalbounded - Type::error to not create a Handle in the common path R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/95904322e79031df765570c88a52e10165c9b384

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -134 lines) Patch
M runtime/lib/mirrors.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/compiler_stats.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +18 lines, -12 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 16 chunks +63 lines, -44 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/profiler_service.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +18 lines, -27 lines 1 comment Download
M runtime/vm/snapshot_test.cc View 3 chunks +34 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
siva
4 years, 7 months ago (2016-05-04 21:25:17 UTC) #3
regis
LGTM
4 years, 7 months ago (2016-05-04 21:44:14 UTC) #4
siva
Committed patchset #1 (id:1) manually as 95904322e79031df765570c88a52e10165c9b384 (presubmit successful).
4 years, 7 months ago (2016-05-04 22:31:00 UTC) #6
rmacnak
4 years, 7 months ago (2016-05-05 03:58:29 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1952023002/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (left):

https://codereview.chromium.org/1952023002/diff/1/runtime/vm/raw_object.h#old...
runtime/vm/raw_object.h:457: return IsStringClassId(GetClassId());
This isn't the same as GetClassId() == kStringCid.  Breaks symbol table
compaction, suppressed in 257b3a82b8d3d1cee57956deb214e6ef1aba3ac1.

Powered by Google App Engine
This is Rietveld 408576698