Mac: Plumb AcceleratedWidgetMac through RWHVMac

Mac: Plumb AcceleratedWidgetMac through RWHVMac

The AcceleratedWidgetMac has the CALayers for content and for low power
fullscreen mode. Expose this through RenderWidgetHostView, so that it
can be accessed by the fullscreen NSWindow.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4202438c3b04ab7ed89767349b77706e1d118c07
Cr-Commit-Position: refs/heads/master@{#391895}

[ccameron, 2016-05-04 20:28:54]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2016-05-04 20:28:55]

I was considering creating some sort of abstract interface in
ui/accelerated_widget_mac -- something to the effect of
"AcceleratedWidgetButNotReallyForCocoa", and having AcceleratedWidgetMac
implement that, but it seemed needlessly complicated for the moment. I wouldn't
be opposed to adding it later, if we think that's a good idea.

[Avi (use Gerrit), 2016-05-04 21:01:03]

https://codereview.chromium.org/1952003002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/1952003002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.h:101:
ui::AcceleratedWidgetMac* GetAcceleratedWidgetMac() const override;
Why is this the only thing in an #if MACOSX block? Can we avoid putting this
into _base?

[ccameron, 2016-05-04 21:09:34]

Description was changed from

==========
Mac: Plumb AcceleratedWidgetMac through RWHVMac

The AcceleratedWidgetMac has the CALayers for content and for low power
fullscreen mode. Expose this through RenderWidgetHostView, so that it
can be accessed by the fullscreen NSWindow.

BUG=594460
==========

to

==========
Mac: Plumb AcceleratedWidgetMac through RWHVMac

The AcceleratedWidgetMac has the CALayers for content and for low power
fullscreen mode. Expose this through RenderWidgetHostView, so that it
can be accessed by the fullscreen NSWindow.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ccameron, 2016-05-04 21:09:56]

Good point -- put it with the other #if MAC parts.

[ccameron, 2016-05-05 18:44:50]

postprandial ping

[Avi (use Gerrit), 2016-05-05 19:20:25]

lgtm with grimace that we have all this random Mac code in this non-Mac class.
Not your fault, anyway.

[ccameron, 2016-05-05 19:22:10]

Thanks!

Yes, indeed, grumble.

[ccameron, 2016-05-05 19:22:15]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-05-05 19:22:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952003002/20001

[commit-bot: I haz the power, 2016-05-05 20:29:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 20:31:11]

Description was changed from

==========
Mac: Plumb AcceleratedWidgetMac through RWHVMac

The AcceleratedWidgetMac has the CALayers for content and for low power
fullscreen mode. Expose this through RenderWidgetHostView, so that it
can be accessed by the fullscreen NSWindow.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Mac: Plumb AcceleratedWidgetMac through RWHVMac

The AcceleratedWidgetMac has the CALayers for content and for low power
fullscreen mode. Expose this through RenderWidgetHostView, so that it
can be accessed by the fullscreen NSWindow.

BUG=594460
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4202438c3b04ab7ed89767349b77706e1d118c07
Cr-Commit-Position: refs/heads/master@{#391895}
==========

[commit-bot: I haz the power, 2016-05-05 20:31:13]

Patchset 2 (id:??) landed as
https://crrev.com/4202438c3b04ab7ed89767349b77706e1d118c07
Cr-Commit-Position: refs/heads/master@{#391895}