Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1951993002: update gitignore and fix build (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
vsm, sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
this fixes 1 of the 3 failures in https://s3.amazonaws.com/archive.travis-ci.org/jobs/127863731/log.txt the only one I could repro ...
4 years, 7 months ago (2016-05-04 20:04:07 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-04 20:12:46 UTC) #3
Jennifer Messerly
4 years, 7 months ago (2016-05-04 20:48:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc9680c49dabc0db6790a9bbcef8a27da0eb108e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698