Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1951943002: [Mac][Material Design] Fix AutocompleteTextFieldCell tests for MD. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix AutocompleteTextFieldCell tests for MD. The expected textframe origin of 0 causes a test failure (under Material Design the expected textframe origin is 1). R=avi@chromium.org BUG=609158 Committed: https://crrev.com/9c711851334428d698079b73f17d1bb0620960b8 Cr-Commit-Position: refs/heads/master@{#391649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-04 17:02:15 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-04 18:02:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951943002/1
4 years, 7 months ago (2016-05-04 20:44:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 21:43:08 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 21:44:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c711851334428d698079b73f17d1bb0620960b8
Cr-Commit-Position: refs/heads/master@{#391649}

Powered by Google App Engine
This is Rietveld 408576698