components/json_schema/json_schema_validator_unittest.cc - Issue 195193002: Add regular expression support in json_schema component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/json_schema/json_schema_validator_unittest.cc

Issue 195193002: Add regular expression support in json_schema component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/json_schema/json_schema_validator.cc ('K') | « components/json_schema/json_schema_validator.cc ('k') | components/json_schema/json_schema_validator_unittest_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/json_schema/json_schema_validator_unittest.cc

diff --git a/components/json_schema/json_schema_validator_unittest.cc b/components/json_schema/json_schema_validator_unittest.cc

index 73809de5c860fd2b52a5b23a862fcc7e36994cfe..95f396b9df2640736ef26e2276cf16409e9516f3 100644

--- a/components/json_schema/json_schema_validator_unittest.cc

+++ b/components/json_schema/json_schema_validator_unittest.cc

@@ -134,6 +134,26 @@ TEST(JSONSchemaValidator, IsValidSchema) {

EXPECT_TRUE(JSONSchemaValidator::IsValidSchema(

"{"

" \"type\": \"object\","

+ " \"patternProperties\": {"

+ " \".\": { \"type\": \"any\" },"

+ " \"foo\": { \"type\": \"any\" },"

+ " \"^foo$\": { \"type\": \"any\" },"

+ " \"foo+\": { \"type\": \"any\" },"

+ " \"foo?\": { \"type\": \"any\" },"

+ " \"fo{2,4}\": { \"type\": \"any\" },"

+ " \"(left)|(right)\": { \"type\": \"any\" }"

+ " }"

+ "}", &error)) << error;

+ EXPECT_FALSE(JSONSchemaValidator::IsValidSchema(

+ "{"

+ " \"type\": \"object\","

+ " \"patternProperties\": {"

+ " \"(left\": { \"type\": \"any\" }"

+ " }"

+ "}", &error)) << error;

+ EXPECT_TRUE(JSONSchemaValidator::IsValidSchema(

+ "{"

+ " \"type\": \"object\","

" \"unknown attribute\": \"that should just be ignored\""

"}",

JSONSchemaValidator::OPTIONS_IGNORE_UNKNOWN_ATTRIBUTES,