Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1951903003: Assert destination handler exists in AudioParam (Closed)

Created:
4 years, 7 months ago by Raymond Toy
Modified:
4 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert destination handler exists in AudioParam AudioParam's require the destination handler to exist because they need access to the sample rate and such. Make sure it exists. Also, don't call initialize() in the OfflineAudioContext constructor if we failed to construct the context completely. BUG=608878 TEST=none Committed: https://crrev.com/d7722027437aa40e2c7b33bc92a4dc278daec2d0 Cr-Commit-Position: refs/heads/master@{#392100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioParam.h View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raymond Toy
PTAL
4 years, 7 months ago (2016-05-05 19:46:32 UTC) #2
hongchan
lgtm
4 years, 7 months ago (2016-05-05 21:09:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951903003/1
4 years, 7 months ago (2016-05-06 17:08:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 18:16:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 18:17:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7722027437aa40e2c7b33bc92a4dc278daec2d0
Cr-Commit-Position: refs/heads/master@{#392100}

Powered by Google App Engine
This is Rietveld 408576698