Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1951873003: More gtest overrides to fix OSX GN build (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build_overrides/gtest.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-04 23:26:59 UTC) #2
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-04 23:58:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951873003/1
4 years, 7 months ago (2016-05-05 00:06:01 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 00:35:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/41aad19ba366540bd4efa20a9009ac1c70a8...

Powered by Google App Engine
This is Rietveld 408576698