Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1951863004: API changes to support sending characteristic properties. (Closed)

Created:
4 years, 7 months ago by rkc
Modified:
4 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluez_changes_for_properties
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

API changes to support sending characteristic properties. This CL adds the code needed to send the characteristic properties given by an app to BlueZ. R=scheib@chromium.org BUG=606853 Committed: https://crrev.com/4e252b946901d066eefc22e71240619ab3829ac9 Cr-Commit-Position: refs/heads/master@{#392412}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc View 1 2 chunks +56 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1947353002 Patch 20001

Messages

Total messages: 17 (6 generated)
rkc
4 years, 7 months ago (2016-05-05 03:38:39 UTC) #1
scheib
https://codereview.chromium.org/1951863004/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc (right): https://codereview.chromium.org/1951863004/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc#newcode187 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:187: Add a compile time check that all enum values ...
4 years, 7 months ago (2016-05-07 01:15:06 UTC) #2
rkc
https://codereview.chromium.org/1951863004/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc (right): https://codereview.chromium.org/1951863004/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc#newcode187 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:187: On 2016/05/07 01:15:06, scheib wrote: > Add a compile ...
4 years, 7 months ago (2016-05-07 20:39:23 UTC) #3
scheib
LGTM
4 years, 7 months ago (2016-05-08 03:31:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951863004/20001
4 years, 7 months ago (2016-05-09 10:07:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225435)
4 years, 7 months ago (2016-05-09 11:02:25 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951863004/20001
4 years, 7 months ago (2016-05-09 17:50:50 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 18:55:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951863004/20001
4 years, 7 months ago (2016-05-09 20:23:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 20:28:56 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:30:59 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4e252b946901d066eefc22e71240619ab3829ac9
Cr-Commit-Position: refs/heads/master@{#392412}

Powered by Google App Engine
This is Rietveld 408576698