Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1951853006: Revert of Use correct clip container when computing acl for scroll children (Closed)

Created:
4 years, 7 months ago by Ian Vollick
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use correct clip container when computing acl for scroll children Reason for revert: Caused issue 608410 Original issue's description: > Use correct clip container when computing acl for scroll children > > Kudos to erick@ for the reduced test case. > > BUG=603997 > > Committed: https://crrev.com/94d5fad34f0351e61fd658ca4ed93648c415620d > Cr-Commit-Position: refs/heads/master@{#390199} TBR=wangxianzhu@chromium.org BUG=603997, 608410 Committed: https://crrev.com/efadb1362a06b05bc877a13f50010ddf3ce50ccd Cr-Commit-Position: refs/heads/master@{#391913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951853006/1
4 years, 7 months ago (2016-05-05 19:00:39 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 21:00:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951853006/1
4 years, 7 months ago (2016-05-05 21:16:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 21:40:13 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 21:42:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efadb1362a06b05bc877a13f50010ddf3ce50ccd
Cr-Commit-Position: refs/heads/master@{#391913}

Powered by Google App Engine
This is Rietveld 408576698