Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1951853002: [turbofan] Inline the allocation fast path. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline the allocation fast path. Now that everything is properly wired to the effect chain when we get to ChangeLowering, we can safely inline the allocation fast path and only need to consule the slow path stub fallback when bump pointer allocation fails. R=jarin@chromium.org BUG=v8:4931 LOG=n Committed: https://crrev.com/ce38a8a92a3e4215a5c4f2413829189a5c2bf060 Cr-Commit-Position: refs/heads/master@{#36022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -17 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +67 lines, -11 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-04 12:10:40 UTC) #1
Benedikt Meurer
Hey Jaro, Finally there. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-04 12:12:05 UTC) #2
Jarin
Cool, lgtm!
4 years, 7 months ago (2016-05-04 12:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951853002/1
4 years, 7 months ago (2016-05-04 12:18:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 12:43:06 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:44:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce38a8a92a3e4215a5c4f2413829189a5c2bf060
Cr-Commit-Position: refs/heads/master@{#36022}

Powered by Google App Engine
This is Rietveld 408576698