Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: scripts/slave/recipe_modules/skia/api.py

Issue 1951843002: Skia: Add --colorImages to DM (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/skia/api.py
diff --git a/scripts/slave/recipe_modules/skia/api.py b/scripts/slave/recipe_modules/skia/api.py
index 5df1998d91125fe7e8385649b59086b13df77b14..3192476be3aa3db8bfaae37b41721996e5597b25 100644
--- a/scripts/slave/recipe_modules/skia/api.py
+++ b/scripts/slave/recipe_modules/skia/api.py
@@ -712,6 +712,8 @@ print json.dumps({'ccache': ccache})
'--skps', self.device_dirs.skp_dir,
'--images', self.flavor.device_path_join(
self.device_dirs.images_dir, 'dm'),
+ '--colorImages', self.flavor.device_path_join(
+ self.device_dirs.images_dir, 'colorspace'),
borenet 2016/05/04 12:09:55 I have a couple of concerns: 1. This will break fo
scroggo 2016/05/04 12:50:32 Isn't this a more general problem any time we add
borenet 2016/05/04 12:56:16 Yeah, it's a general problem. I just feel I need
'--nameByHash',
'--properties'
] + properties
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698