Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Issue 1951833003: Use property accessor elements for type inference rather than top level variable elements. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use property accessor elements for type inference rather than top level variable elements. This makes the behavior of the linker more consistent with the language spec. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6a6d6350277f91ba8d0fb128477cd13cf3853912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -52 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 13 chunks +34 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-04 12:15:47 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-04 13:54:23 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-04 15:02:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a6d6350277f91ba8d0fb128477cd13cf3853912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698