Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 195183003: Don't use a temp file for changelog in push-to-trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Don't use a temp file for changelog in push-to-trunk. This is part of getting rid of the ChangeLog on bleeding_edge and directly modifying it on trunk. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/push-to-trunk/push_to_trunk.py View 4 chunks +7 lines, -8 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-11 14:58:48 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-11 15:40:47 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-12 07:40:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698