Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: tools/telemetry/telemetry/page/page_runner_repeat.py

Issue 19518009: Implement 'skip_navigate_on_repeat' option (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner_repeat.py
diff --git a/tools/telemetry/telemetry/page/page_runner_repeat.py b/tools/telemetry/telemetry/page/page_runner_repeat.py
index acec0b0b714b01916fd833569d53a0cee77b2de8..5c80f5c68fd00010791e04ebb740d174b355d1b6 100644
--- a/tools/telemetry/telemetry/page/page_runner_repeat.py
+++ b/tools/telemetry/telemetry/page/page_runner_repeat.py
@@ -52,3 +52,10 @@ class PageRunnerRepeatState(object):
self.page_iters >= self.options.page_repeat_iters):
return False
return True
+
+ def ShouldNavigate(self, skip_navigate_on_repeat):
+ """Returns whether we are navigating to pages on page repeats.
+
+ Always navigate on the first iteration of a page and on every new pageset.
+ """
+ return self.page_iters == 0 or not skip_navigate_on_repeat
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698