Remove HangoutsPrivate API

Remove HangoutsPrivate API

BUG=601233
Committed: https://crrev.com/caf741145de00dbc1cf7f13e8fbb3a011f606aeb
Cr-Commit-Position: refs/heads/master@{#391720}

[xiaoyinh(OOO Sep 11-29), 2016-05-04 22:00:54]

xiaoyinh@chromium.org changed reviewers:
+ benwells@chromium.org, mpearson@google.com, rockot@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-05-04 22:02:46]

xiaoyinh@chromium.org changed reviewers:
+ rkc@google.com

[Mark P, 2016-05-04 22:06:57]

Did you forget to add histograms.xml to this changelist?

[xiaoyinh(OOO Sep 11-29), 2016-05-04 22:16:50]

On 2016/05/04 22:06:57, Mark P wrote:
> Did you forget to add histograms.xml to this changelist?

Based on the comment in histograms.xml
<enum name="ExtensionEvents" type="int">
<!-- Generated from extensions/browser/extension_event_histogram_value.h -->

HANGOUTS_PRIVATE_ON_HANGOUT_REQUESTED is generated from
extension_event_histogram_value.h

So I think it should reflect the rename as well?

[Mark P, 2016-05-04 22:26:16]

On 2016/05/04 22:16:50, xiaoyinh wrote:
> On 2016/05/04 22:06:57, Mark P wrote:
> > Did you forget to add histograms.xml to this changelist?
> 
> Based on the comment in histograms.xml
> <enum name="ExtensionEvents" type="int">
> <!-- Generated from extensions/browser/extension_event_histogram_value.h -->
> 
> HANGOUTS_PRIVATE_ON_HANGOUT_REQUESTED is generated from
> extension_event_histogram_value.h
> 
> So I think it should reflect the rename as well?

In that file, you may've seen the comment
  // Last entry: Add new entries above, then run:
  // python tools/metrics/histograms/update_extension_histograms.py
  ENUM_BOUNDARY

Please run that script.

--mark

[xiaoyinh(OOO Sep 11-29), 2016-05-04 22:35:23]

On 2016/05/04 22:26:16, Mark P wrote:
> On 2016/05/04 22:16:50, xiaoyinh wrote:
> > On 2016/05/04 22:06:57, Mark P wrote:
> > > Did you forget to add histograms.xml to this changelist?
> > 
> > Based on the comment in histograms.xml
> > <enum name="ExtensionEvents" type="int">
> > <!-- Generated from extensions/browser/extension_event_histogram_value.h -->
> > 
> > HANGOUTS_PRIVATE_ON_HANGOUT_REQUESTED is generated from
> > extension_event_histogram_value.h
> > 
> > So I think it should reflect the rename as well?
> 
> In that file, you may've seen the comment
>   // Last entry: Add new entries above, then run:
>   // python tools/metrics/histograms/update_extension_histograms.py
>   ENUM_BOUNDARY
> 
> Please run that script.
> 
> --mark

Done.

Thanks for the information.

[Mark P, 2016-05-04 22:39:30]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2016-05-04 22:39:31]

histograms.xml lgtm

[Ken Rockot(use gerrit already), 2016-05-04 22:40:56]

lgtm

[xiaoyinh(OOO Sep 11-29), 2016-05-04 22:55:31]

I have a question regarding hangoutsPrivate.html.
There are another 2 places that refers hangoutsPrivate.html.

chrome/common/extensions/docs/server2/known_broken_links.json

[
    302,
    "apps/private_apis.html",
    "apps/hangoutsPrivate.html",
    "redirects to /extensions/hangoutsPrivate.html"
  ],


And in 
chrome/common/extensions/docs/server2/test_data/gitiles_file_system/public_extensions

{
      "mode": 33188,
      "type": "blob",
      "id": "ca32d4cb6362db6ee899ed7dcff272645f16ad11",
      "name": "hangoutsPrivate.html"
    },

I'm not sure whether they are auto-generated, or I need to delete these as well?
Any script/tests I should run?

Thanks
Sarah

[Ken Rockot(use gerrit already), 2016-05-04 22:59:12]

On 2016/05/04 at 22:55:31, xiaoyinh wrote:
> I have a question regarding hangoutsPrivate.html.
> There are another 2 places that refers hangoutsPrivate.html.
> 
> chrome/common/extensions/docs/server2/known_broken_links.json
> 
> [
>     302,
>     "apps/private_apis.html",
>     "apps/hangoutsPrivate.html",
>     "redirects to /extensions/hangoutsPrivate.html"
>   ],
> 
> 
> And in 
>
chrome/common/extensions/docs/server2/test_data/gitiles_file_system/public_extensions
> 
> {
>       "mode": 33188,
>       "type": "blob",
>       "id": "ca32d4cb6362db6ee899ed7dcff272645f16ad11",
>       "name": "hangoutsPrivate.html"
>     },
> 
> I'm not sure whether they are auto-generated, or I need to delete these as
well? Any script/tests I should run?
> 
> Thanks
> Sarah

The latter is just test data which you can leave alone. Please go ahead and
remove the entry from known_broken_links.json

[xiaoyinh(OOO Sep 11-29), 2016-05-04 23:08:52]

On 2016/05/04 22:59:12, Ken Rockot wrote:
> On 2016/05/04 at 22:55:31, xiaoyinh wrote:
> > I have a question regarding hangoutsPrivate.html.
> > There are another 2 places that refers hangoutsPrivate.html.
> > 
> > chrome/common/extensions/docs/server2/known_broken_links.json
> > 
> > [
> >     302,
> >     "apps/private_apis.html",
> >     "apps/hangoutsPrivate.html",
> >     "redirects to /extensions/hangoutsPrivate.html"
> >   ],
> > 
> > 
> > And in 
> >
>
chrome/common/extensions/docs/server2/test_data/gitiles_file_system/public_extensions
> > 
> > {
> >       "mode": 33188,
> >       "type": "blob",
> >       "id": "ca32d4cb6362db6ee899ed7dcff272645f16ad11",
> >       "name": "hangoutsPrivate.html"
> >     },
> > 
> > I'm not sure whether they are auto-generated, or I need to delete these as
> well? Any script/tests I should run?
> > 
> > Thanks
> > Sarah
> 
> The latter is just test data which you can leave alone. Please go ahead and
> remove the entry from known_broken_links.json

Done. Thanks!

[xiaoyinh(OOO Sep 11-29), 2016-05-04 23:27:26]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 23:27:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951783003/40001

[commit-bot: I haz the power, 2016-05-05 00:32:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 00:32:38]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2016-05-05 00:33:14]

The CQ bit was checked by xiaoyinh@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-05-05 00:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/1951783003/#ps40001
(title: "Remove entry in known_broken_links.json")

[commit-bot: I haz the power, 2016-05-05 00:33:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951783003/40001

[commit-bot: I haz the power, 2016-05-05 00:40:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-05 00:41:27]

Description was changed from

==========
Remove HangoutsPrivate API

BUG=601233
==========

to

==========
Remove HangoutsPrivate API

BUG=601233

Committed: https://crrev.com/caf741145de00dbc1cf7f13e8fbb3a011f606aeb
Cr-Commit-Position: refs/heads/master@{#391720}
==========

[commit-bot: I haz the power, 2016-05-05 00:41:28]

Patchset 3 (id:??) landed as
https://crrev.com/caf741145de00dbc1cf7f13e8fbb3a011f606aeb
Cr-Commit-Position: refs/heads/master@{#391720}