Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4998)

Unified Diff: chrome/test/BUILD.gn

Issue 1951783002: Remove --enable-mac-views-app-list on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | ui/app_list/app_list_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 46e52b45d482d252f20214e9641df4fd9516da27..f17ec75128ea43b1d8d0fe0c18d1fd046ed1fa20 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -2156,6 +2156,11 @@ test("unit_tests") {
chrome_tests_unit_gypi_values.chrome_unit_tests_app_list_sources,
".",
"//chrome")
+ if (is_mac) {
+ # This assumes the AppList is views-based but Mac only links browser parts
+ # for the Cocoa implementation."
+ sources -= [ "../browser/ui/app_list/app_list_shower_views_unittest.cc" ]
+ }
deps += [ "//ui/app_list:test_support" ]
}
if (enable_app_list && is_chromeos) {
@@ -2163,10 +2168,6 @@ test("unit_tests") {
chrome_tests_unit_gypi_values.chrome_unit_tests_app_list_chromeos_sources,
".",
"//chrome")
- sources += rebase_path(
- chrome_tests_unit_gypi_values.chrome_unit_tests_app_list_chromeos_arc_sources,
- ".",
- "//chrome")
deps += [ "//components/arc:arc_test_support" ]
}
if (enable_plugins && !enable_plugin_installation) {
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | ui/app_list/app_list_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698