Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: chrome/test/BUILD.gn

Issue 1951783002: Remove --enable-mac-views-app-list on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gn on not mac Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 46e52b45d482d252f20214e9641df4fd9516da27..443b2f900c0b8878802b035feebf5f90ed0e7f60 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -2156,6 +2156,10 @@ test("unit_tests") {
chrome_tests_unit_gypi_values.chrome_unit_tests_app_list_sources,
".",
"//chrome")
+ if (is_mac) {
+ # This assumes the AppList is views-based.
msw 2016/05/05 01:51:07 ditto nit: "and Mac uses Cocoa"?
tapted 2016/05/05 02:53:42 Done.
+ sources -= [ "../browser/ui/app_list/app_list_shower_views_unittest.cc" ]
+ }
deps += [ "//ui/app_list:test_support" ]
}
if (enable_app_list && is_chromeos) {

Powered by Google App Engine
This is Rietveld 408576698